From 8c90ab653434cdb278cae06aa43eaa6635ab9610 Mon Sep 17 00:00:00 2001 From: mateo-berri <277851410+mateo-berri@users.noreply.github.com> Date: Fri, 16 Oct 2026 14:45:06 -0700 Subject: [PATCH] test(cli): drop the browser launcher test that started a subprocess --- tests/unit/proxy/client/cli/test_auto_sign_in.py | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/tests/unit/proxy/client/cli/test_auto_sign_in.py b/tests/unit/proxy/client/cli/test_auto_sign_in.py index 949a0321f75..36bb5a31d3b 100644 --- a/tests/unit/proxy/client/cli/test_auto_sign_in.py +++ b/tests/unit/proxy/client/cli/test_auto_sign_in.py @@ -10,7 +10,7 @@ from click.testing import CliRunner, Result from litellm.proxy.client.cli import cli from litellm.proxy.client.cli.commands.auth import CliTokenData, get_stored_api_key, save_token -from litellm.proxy.client.cli.commands.auto_sign_in import open_browser_off_stdout, pkce_browser_sign_in +from litellm.proxy.client.cli.commands.auto_sign_in import pkce_browser_sign_in from litellm.proxy.client.cli.commands.pkce_login import PkceCredential, PkceFailure, pkce_token_record BASE_URL: Final = "https://proxy.example.com" @@ -215,19 +215,6 @@ def test_a_browser_the_user_picked_starts_the_sign_in_and_names_how_long_it_wait ] -def test_the_browser_launcher_keeps_stdout_clean_and_never_rings_the_terminal_bell( - capfd: pytest.CaptureFixture[str], monkeypatch: pytest.MonkeyPatch, tmp_path: Path -): - chatty_browser = tmp_path / "chatty-browser" - chatty_browser.write_text('#!/bin/sh\necho "Opening in existing browser session."\n') - chatty_browser.chmod(0o755) - monkeypatch.setenv("BROWSER", str(chatty_browser)) - - open_browser_off_stdout(f"{BASE_URL}/v1/cli/authorize?state=fake") - - assert capfd.readouterr() == ("", "Opening in existing browser session.\n") - - @pytest.mark.parametrize( ("command", "method", "path", "body"), [