scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-09 03:18:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 109

fix(ui): correct budget window reset hints for timezone and weekday

Browse source 
The Budget Window editor hardcoded "midnight UTC" and labeled the weekly
window as resetting on Sunday. The backend computes resets in the
configured litellm_settings.timezone and anchors the weekly window on
Monday, so the hints misled operators about when spend actually resets.

Point the hints at litellm_settings.timezone (noting the UTC default) and
fix the weekly label to Monday. Add a unit test that fails if the Sunday
or fixed-UTC wording returns.
This commit is contained in:
SeongWoon Cho 2026-09-15 18:07:31 +09:00
parent 3ed6c19b8d
commit 8905ca8a8d
No known key found for this signature in database
2 changed files with 34 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
ui/litellm-dashboard/src/components/key_team_helpers/BudgetWindowsEditor.test.ts Normal file
View file

@ -0,0 +1,29 @@
import { describe, expect, it } from "vitest";
import { BUDGET_WINDOW_OPTIONS } from "./BudgetWindowsEditor";
const hintFor = (value: string): string => {
const option = BUDGET_WINDOW_OPTIONS.find((o) => o.value === value);
if (!option) throw new Error(`no budget window option for ${value}`);
return option.resetHint;
};
describe("BUDGET_WINDOW_OPTIONS reset hints", () => {
it("describes the weekly window as resetting on Monday, matching the backend", () => {
expect(hintFor("7d")).toContain("Monday");
expect(hintFor("7d")).not.toContain("Sunday");
});
it("does not claim a fixed UTC reset, since the backend honors the configured timezone", () => {
for (const option of BUDGET_WINDOW_OPTIONS) {
expect(option.resetHint).not.toContain("midnight UTC");
}
});
it("points at litellm_settings.timezone and its UTC default for every window that resets at a time of day", () => {
for (const value of ["24h", "7d", "30d"]) {
expect(hintFor(value)).toContain("litellm_settings.timezone");
expect(hintFor(value)).toContain("defaults to UTC");
}
});
});

8
ui/litellm-dashboard/src/components/key_team_helpers/BudgetWindowsEditor.tsx
View file

@ -8,11 +8,13 @@ export interface BudgetWindowEntry {
max_budget: number | null;
}
const RESET_TIMEZONE_NOTE = "in the proxy timezone (litellm_settings.timezone, defaults to UTC)";
export const BUDGET_WINDOW_OPTIONS = [
{ value: "1h", label: "Hourly", resetHint: "Resets every hour" },
{ value: "24h", label: "Daily", resetHint: "Resets daily at midnight UTC" },
{ value: "7d", label: "Weekly", resetHint: "Resets every Sunday at midnight UTC" },
{ value: "30d", label: "Monthly", resetHint: "Resets on the 1st of every month at midnight UTC" },
{ value: "24h", label: "Daily", resetHint: `Resets daily at midnight ${RESET_TIMEZONE_NOTE}` },
{ value: "7d", label: "Weekly", resetHint: `Resets every Monday at midnight ${RESET_TIMEZONE_NOTE}` },
{ value: "30d", label: "Monthly", resetHint: `Resets on the 1st of each month at midnight ${RESET_TIMEZONE_NOTE}` },
];
interface BudgetWindowsEditorProps {