scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-08 03:08:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 114

trust only server legacy file flag

Browse source
This commit is contained in:
user 2026-05-01 18:32:26 -07:00
parent bb8f6fd5e2
commit 8791f634de
2 changed files with 19 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
litellm/litellm_core_utils/cloud_storage_security.py
View file

@ -116,15 +116,13 @@ def should_allow_legacy_cloud_file_ids(
) -> bool:
value = None
if isinstance(litellm_params, Mapping):
value = litellm_params.get("allow_legacy_cloud_file_ids")
if value is None:
trusted_model_credentials = litellm_params.get(
"_litellm_internal_model_credentials"
trusted_model_credentials = litellm_params.get(
"_litellm_internal_model_credentials"
)
if isinstance(trusted_model_credentials, _MAPPING_PROXY_TYPE):
value = cast(Mapping[str, Any], trusted_model_credentials).get(
"allow_legacy_cloud_file_ids"
)
if isinstance(trusted_model_credentials, _MAPPING_PROXY_TYPE):
value = cast(Mapping[str, Any], trusted_model_credentials).get(
"allow_legacy_cloud_file_ids"
)
if isinstance(value, bool):
return value

26
tests/test_litellm/llms/vertex_ai/files/test_vertex_ai_files_transformation.py
View file

@ -74,17 +74,15 @@ class TestParseGcsUri:
litellm_params={"bucket_name": "my-bucket"},
)
def test_should_allow_legacy_object_path_when_server_flag_enabled(self, config):
bucket, encoded = config._parse_gcs_uri(
"gs://my-bucket/private/object.txt",
litellm_params={
"bucket_name": "my-bucket",
"allow_legacy_cloud_file_ids": True,
},
)
assert bucket == "my-bucket"
assert encoded == urllib.parse.quote("private/object.txt", safe="")
def test_should_reject_request_supplied_legacy_flag(self, config):
with pytest.raises(ValueError, match="LiteLLM-managed"):
config._parse_gcs_uri(
"gs://my-bucket/private/object.txt",
litellm_params={
"bucket_name": "my-bucket",
"allow_legacy_cloud_file_ids": True,
},
)
def test_should_allow_legacy_object_path_with_trusted_server_flag(self, config):
trusted_credentials = MappingProxyType({"allow_legacy_cloud_file_ids": True})
@ -112,11 +110,12 @@ class TestParseGcsUri:
)
def test_should_keep_configured_prefix_for_legacy_object_path(self, config):
trusted_credentials = MappingProxyType({"allow_legacy_cloud_file_ids": True})
bucket, encoded = config._parse_gcs_uri(
"gs://my-bucket/team-a/private/object.txt",
litellm_params={
"bucket_name": "my-bucket/team-a",
"allow_legacy_cloud_file_ids": True,
"_litellm_internal_model_credentials": trusted_credentials,
},
)
@ -124,12 +123,13 @@ class TestParseGcsUri:
assert encoded == urllib.parse.quote("team-a/private/object.txt", safe="")
def test_should_reject_legacy_object_outside_configured_prefix(self, config):
trusted_credentials = MappingProxyType({"allow_legacy_cloud_file_ids": True})
with pytest.raises(ValueError, match="configured storage prefix"):
config._parse_gcs_uri(
"gs://my-bucket/team-b/private/object.txt",
litellm_params={
"bucket_name": "my-bucket/team-a",
"allow_legacy_cloud_file_ids": True,
"_litellm_internal_model_credentials": trusted_credentials,
},
)