From 82fd632153f649fab446fbedc6f1b83b65af21db Mon Sep 17 00:00:00 2001 From: ryan-crabbe-berri Date: Sat, 19 Sep 2026 11:22:01 -0700 Subject: [PATCH] test(ui): share one chart bar lookup across Top Virtual Keys tests The key_exists chart test added a second direct DOM lookup for the Recharts bars, which exposes no role or label, and pushed testing-library/no-node-access over its budget (709 > 707). Both chart tests now go through one helper --- .../UsagePage/components/EntityUsage/TopKeyView.test.tsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ui/litellm-dashboard/src/components/UsagePage/components/EntityUsage/TopKeyView.test.tsx b/ui/litellm-dashboard/src/components/UsagePage/components/EntityUsage/TopKeyView.test.tsx index e1d64ab03bd..e65094c5228 100644 --- a/ui/litellm-dashboard/src/components/UsagePage/components/EntityUsage/TopKeyView.test.tsx +++ b/ui/litellm-dashboard/src/components/UsagePage/components/EntityUsage/TopKeyView.test.tsx @@ -29,6 +29,8 @@ vi.mock("../../../templates/key_info_view", () => ({ ), })); +const chartBars = (container: HTMLElement) => Array.from(container.querySelectorAll("path.recharts-rectangle")); + describe("TopKeyView", () => { const mockUseAuthorized = vi.mocked(useAuthorized); const mockKeyInfoV1Call = vi.mocked(networking.keyInfoV1Call); @@ -206,7 +208,7 @@ describe("TopKeyView", () => { await user.click(screen.getByRole("button", { name: "Chart View" })); - const bars = container.querySelectorAll("path.recharts-rectangle"); + const bars = chartBars(container); expect(bars).toHaveLength(1); expect(bars[0]).toHaveAttribute("fill", "var(--color-cyan-500, #06b6d4)"); expect(screen.getAllByText("A Very Lon...").length).toBeGreaterThan(0); @@ -511,7 +513,7 @@ describe("TopKeyView", () => { await user.click(screen.getByText("session-key")); await user.click(screen.getByRole("button", { name: "Chart View" })); - const bars = container.querySelectorAll("path.recharts-rectangle"); + const bars = chartBars(container); expect(bars).toHaveLength(2); bars.forEach((bar) => fireEvent.click(bar));