From 8207f98112bc2810ee42f67bc234651d582ea4ae Mon Sep 17 00:00:00 2001 From: mateo-berri <277851410+mateo-berri@users.noreply.github.com> Date: Mon, 9 Nov 2026 12:52:38 -0800 Subject: [PATCH] test(proxy): stop pinning the Responses stream terminator in the fallback metadata test Main ends Responses streams without data: [DONE] since #47980, so the test reads the event frames whether or not a terminator follows them, and passes both before and after that change merges --- tests/unit/proxy/proxy_server/test_streaming_helpers.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/unit/proxy/proxy_server/test_streaming_helpers.py b/tests/unit/proxy/proxy_server/test_streaming_helpers.py index 80a94f0fc51..689f9aba45e 100644 --- a/tests/unit/proxy/proxy_server/test_streaming_helpers.py +++ b/tests/unit/proxy/proxy_server/test_streaming_helpers.py @@ -939,13 +939,12 @@ async def test_responses_stream_sends_fallback_metadata_as_a_typed_event_framed_ ) ] ) - event_frames: Final = frames[:-1] + event_frames: Final = tuple(frame for frame in frames if frame != "data: [DONE]\n\n") payloads: Final = tuple( json.loads(next(line.removeprefix("data: ") for line in frame.splitlines() if line.startswith("data: "))) for frame in event_frames ) - assert frames[-1] == "data: [DONE]\n\n" assert tuple(payload.get("type") for payload in payloads) == ( "response.created", "litellm.fallback_metadata",