scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-19 00:01:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 88

fix(memory): retain observation metadata in dashboard corrections

Browse source
This commit is contained in:
moe-berri 2026-09-12 13:28:58 -07:00
parent 5d197c18e3
commit 80bb2488b3
2 changed files with 67 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
ui/litellm-dashboard/src/app/(dashboard)/memory/_components/AutomaticMemoryEntries.tsx
View file

@ -125,15 +125,21 @@ export function AutomaticMemoryEntries({ userId, readOnly }: Readonly<{ userId:
className="space-y-3 rounded-md border p-4"
onSubmit={(event) => {
event.preventDefault();
const body: Capture = {
key: editing.key,
title: editing.title,
content: editing.content,
evidence: editing.evidence,
when_to_use: editing.when_to_use,
scope: editing.scope,
kind: editing.kind,
certainty: editing.certainty,
source: editing.source,
expected_revision: editing.updated_at,
};
save.mutate({
key: keyId,
body: {
key: editing.key,
title: editing.title,
content: editing.content,
evidence: editing.evidence,
expected_revision: editing.updated_at,
},
body,
});
}}
>

55
ui/litellm-dashboard/src/app/(dashboard)/memory/page.integration.test.tsx
View file

@ -10,6 +10,21 @@ vi.unmock("@/lib/toast");
const fetchMock = vi.fn<typeof fetch>();
const calls: { path: string; method: string; body: unknown }[] = [];
const entry = {
memory_id: "entry-1",
key: "demo",
title: "Demo port",
content: "Use port 8123",
evidence: "Fixture recommendation",
when_to_use: "Configuring the demo",
scope: "demo",
kind: "decision",
certainty: "inferred",
source: "fixture.md",
created_at: "2026-09-12T00:00:00Z",
updated_at: "2026-09-12T00:00:00Z",
actor: "u1",
};
const session = (user_role: string) => {
const payload = { key: "sk-test", user_id: "u1", user_role, exp: Math.floor(Date.now() / 1000) + 3600 };
document.cookie = `token=${btoa("{}")}\.${btoa(JSON.stringify(payload))}.signature; path=/`;
@ -30,7 +45,15 @@ beforeEach(async () => {
if (path === "/v2/memory/preference") return { enabled: request.method === "PUT" };
if (path === "/v2/memory/policies") return [];
if (path === "/v1/memory") return { memories: [], total: 0 };
if (path.includes("/key/list")) return { keys: [], total_count: 0, current_page: 1, total_pages: 1 };
if (path === "/v2/memory/status") return { active: true, scope: "key" };
if (path === "/v2/memory/entries") return request.method === "POST" ? entry : [entry];
if (path.includes("/key/list"))
return {
keys: [{ token: "a".repeat(64), key_alias: "QA key" }],
total_count: 1,
current_page: 1,
total_pages: 1,
};
if (path.includes("/team/list") || path.includes("/organization")) return [];
return {};
};
@ -41,6 +64,36 @@ beforeEach(async () => {
});
describe("Gateway memory settings", () => {
it("preserves observation attribution when a person corrects saved content", async () => {
session("internal_user");
const user = userEvent.setup();
renderWithProviders(<Memory />);
await user.click(await screen.findByLabelText("Virtual key"));
await user.click(await screen.findByRole("option", { name: "QA key" }));
await user.click(await screen.findByRole("button", { name: "Edit memory" }));
await user.clear(screen.getByLabelText("Correct this memory"));
await user.type(screen.getByLabelText("Correct this memory"), "Use port 8124");
await user.click(screen.getByRole("button", { name: "Save correction" }));
await waitFor(() =>
expect(calls).toContainEqual({
path: "/v2/memory/entries",
method: "POST",
body: {
key: entry.key,
title: entry.title,
content: "Use port 8124",
evidence: entry.evidence,
when_to_use: entry.when_to_use,
scope: entry.scope,
kind: entry.kind,
certainty: entry.certainty,
source: entry.source,
expected_revision: entry.updated_at,
},
}),
);
});
it("lets an administrator choose automatic activation and a sharing scope", async () => {
session("proxy_admin");
const user = userEvent.setup();