From 7fde31fe08c56778681901d5ff667bf821882e42 Mon Sep 17 00:00:00 2001 From: ryan Date: Fri, 4 Sep 2026 00:16:06 +0000 Subject: [PATCH] fix(ui): fall back to the last page when per-user usage shrinks under the current page Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- .../src/components/per_user_usage.test.tsx | 36 +++++++++++++++---- .../src/components/per_user_usage.tsx | 6 +++- 2 files changed, 35 insertions(+), 7 deletions(-) diff --git a/ui/litellm-dashboard/src/components/per_user_usage.test.tsx b/ui/litellm-dashboard/src/components/per_user_usage.test.tsx index 3ce85580ca8..d5c2216dfd5 100644 --- a/ui/litellm-dashboard/src/components/per_user_usage.test.tsx +++ b/ui/litellm-dashboard/src/components/per_user_usage.test.tsx @@ -98,20 +98,24 @@ describe("PerUserUsage", () => { describe("server pagination", () => { const TOTAL_USERS = 120; - const pageOfUsers = (page: number, pageSize: number): UserRow[] => { + const pageOfUsers = (page: number, pageSize: number, total: number): UserRow[] => { const start = (page - 1) * pageSize; - const count = Math.max(0, Math.min(pageSize, TOTAL_USERS - start)); + const count = Math.max(0, Math.min(pageSize, total - start)); return Array.from({ length: count }, (_, index) => userRow(`user-${start + index + 1}`, "curl/8.0", 5)); }; - beforeEach(() => { + const serveUsers = (total: number) => { mockPerUserAnalyticsCall.mockImplementation(async (_token, page = 1, pageSize = 50) => ({ - results: pageOfUsers(page, pageSize), - total_count: TOTAL_USERS, + results: pageOfUsers(page, pageSize, total), + total_count: total, page, page_size: pageSize, - total_pages: Math.ceil(TOTAL_USERS / pageSize), + total_pages: Math.ceil(total / pageSize), })); + }; + + beforeEach(() => { + serveUsers(TOTAL_USERS); }); const lastCall = () => mockPerUserAnalyticsCall.mock.calls[mockPerUserAnalyticsCall.mock.calls.length - 1]; @@ -154,6 +158,26 @@ describe("PerUserUsage", () => { expect(screen.getByTestId("pagination-next")).toBeDisabled(); }); + it("falls back to the last existing page when the data shrinks under the current page", async () => { + const user = userEvent.setup(); + render(); + await screen.findByText("user-1"); + await user.click(screen.getByTestId("pagination-next")); + await screen.findByText("user-51"); + + serveUsers(60); + await user.click(screen.getByTestId("pagination-next")); + + expect(await screen.findByText("user-60")).toBeInTheDocument(); + expect(mockPerUserAnalyticsCall.mock.calls.slice(-2)).toEqual([ + ["test-token", 3, 50, undefined], + ["test-token", 2, 50, undefined], + ]); + expect(screen.getAllByRole("row")).toHaveLength(11); + expect(screen.getByTestId("pagination-range")).toHaveTextContent("Showing 51-60 of 60"); + expect(screen.getByTestId("pagination-next")).toBeDisabled(); + }); + it("refetches with the selected page size and goes back to the first page", async () => { const user = userEvent.setup(); render(); diff --git a/ui/litellm-dashboard/src/components/per_user_usage.tsx b/ui/litellm-dashboard/src/components/per_user_usage.tsx index 215a2032d4f..57b1a926ec0 100644 --- a/ui/litellm-dashboard/src/components/per_user_usage.tsx +++ b/ui/litellm-dashboard/src/components/per_user_usage.tsx @@ -60,7 +60,11 @@ const PerUserUsage: React.FC = ({ accessToken, selectedTags, pagedTags.length > 0 ? pagedTags : undefined, ) .then((response) => { - if (!stale) setPerUserData(response); + if (stale) return; + setPerUserData(response); + if (response.total_pages > 0 && pagination.pageIndex >= response.total_pages) { + setPagination({ ...pagination, pageIndex: response.total_pages - 1 }); + } }) .catch((error) => console.error("Failed to fetch per-user data:", error));