scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-06 08:16:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 79

fix(budgets): let the model access group spend helper swallow its own failure

Browse source 
The helper already logs through spend_log_error, so re-raising only for
_batch_database_updates to catch and log again was double reporting. Isolate
inside the helper instead and drop the caller's wrapper.
This commit is contained in:
ryan-crabbe-berri 2026-08-29 14:17:45 -07:00
parent 6b2e7f8a1f
commit 7a2f6c4cc2
1 changed files with 10 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
litellm/proxy/db/db_spend_update_writer.py
View file

@ -485,7 +485,7 @@ class DBSpendUpdateWriter:
request_model_access_groups: Sequence[str] = (),
):
"""
Runs all 12 spend-update helpers sequentially inside a single asyncio task.
Runs all 13 spend-update helpers sequentially inside a single asyncio task.
Each helper is wrapped in try/except so one failure doesn't prevent the others.
@ -557,19 +557,13 @@ class DBSpendUpdateWriter:
traceback.format_exc(),
)
try:
await self._update_model_access_group_db(
response_cost=response_cost,
request_model_access_groups=request_model_access_groups,
served_model_id=payload_copy.get("model_id"),
prisma_client=prisma_client,
router=_get_llm_router(),
)
except Exception:
verbose_proxy_logger.debug(
"_batch_database_updates: _update_model_access_group_db failed: %s",
traceback.format_exc(),
)
await self._update_model_access_group_db(
response_cost=response_cost,
request_model_access_groups=request_model_access_groups,
served_model_id=payload_copy.get("model_id"),
prisma_client=prisma_client,
router=_get_llm_router(),
)
_agent_id_for_spend: Final = payload_copy.get("agent_id")
try:
@ -887,7 +881,7 @@ class DBSpendUpdateWriter:
served_model_id: str | None,
prisma_client: PrismaClient | None,
router: _DeploymentLookup | None = None,
):
) -> None:
"""
Update spend for every model access group this request is billed against.
@ -914,7 +908,7 @@ class DBSpendUpdateWriter:
response_cost=response_cost,
)
)
except Exception as e:
except Exception as e: # noqa: BLE001 # isolation: a helper failure must not stop the batch
spend_log_error(
"Spend tracking - failed to enqueue model access group spend update. "
"model_access_groups=%s, response_cost=%s - %s",
@ -923,7 +917,6 @@ class DBSpendUpdateWriter:
str(e),
exc=e,
)
raise e
async def _insert_spend_log_to_db(
self,