scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-21 00:21:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 117

revert: drop the collection gate and keep the import fix

Browse source
This commit is contained in:
Yuneng Jiang 2026-09-15 23:25:33 -07:00
parent 3080ee8013
commit 79cdcbf6c6
No known key found for this signature in database
2 changed files with 0 additions and 69 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.github/workflows/test-code-quality.yml vendored
View file

@ -83,9 +83,6 @@ jobs:
- name: test_e2e_changed_gate
run: uv run --no-sync pytest -q --noconftest -p no:cacheprovider -c /dev/null tests/code_coverage_tests/test_e2e_changed_gate.py tests/code_coverage_tests/test_e2e_idp_stack.py
- name: test_integration_suite_imports
run: uv run --no-sync pytest -q --noconftest -p no:cacheprovider -c /dev/null tests/code_coverage_tests/test_integration_suite_imports.py
- name: router_code_coverage
run: uv run --no-sync python ./tests/code_coverage_tests/router_code_coverage.py

66
tests/code_coverage_tests/test_integration_suite_imports.py
View file

@ -1,66 +0,0 @@
from __future__ import annotations
import os
import re
import subprocess
import sys
from pathlib import Path
from typing import Final
import pytest
REPO_ROOT: Final = Path(__file__).resolve().parents[2]
INTEGRATION_ROOT: Final = REPO_ROOT / "tests" / "integration"
COLLECTION_SUMMARY: Final = re.compile(
r"^(?P<collected>\d+) tests? collected(?:, (?P<errors>\d+) errors?)?", re.MULTILINE
)
def _integration_test_files() -> tuple[Path, ...]:
return tuple(sorted(INTEGRATION_ROOT.rglob("test_*.py")))
def _collect_without_injected_pythonpath(target: str) -> subprocess.CompletedProcess[str]:
env: Final = {key: value for key, value in os.environ.items() if key != "PYTHONPATH"}
return subprocess.run(
(sys.executable, "-m", "pytest", target, "--collect-only", "-q", "-p", "no:cacheprovider"),
cwd=REPO_ROOT,
env=env,
capture_output=True,
text=True,
check=False,
)
def _assert_collected(result: subprocess.CompletedProcess[str], target: str) -> None:
# Both a healthy collection and a failed import exit 4 here, because conftest.py's
# CircleCI-ownership guard fires under GITHUB_ACTIONS; only the summary separates them.
match: Final = COLLECTION_SUMMARY.search(result.stdout)
assert match is not None, (
f"{target} never reached a collection summary, so its imports did not resolve\n"
f"{result.stdout}\n{result.stderr}"
)
assert int(match.group("collected")) > 0, (
f"{target} collected nothing, so nothing was verified\n{result.stdout}"
)
# One broken file among many still reports a count: "83 tests collected, 1 error".
assert match.group("errors") is None, (
f"{target} reported {match.group('errors')} collection error(s)\n{result.stdout}\n{result.stderr}"
)
def test_the_integration_suite_still_has_files_to_guard() -> None:
assert _integration_test_files()
@pytest.mark.parametrize(
"target",
[str(path.relative_to(REPO_ROOT)) for path in _integration_test_files()],
)
def test_each_integration_file_collects_the_way_its_docs_document_it(target: str) -> None:
_assert_collected(_collect_without_injected_pythonpath(target), target)
def test_the_whole_integration_directory_collects_without_an_injected_pythonpath() -> None:
target: Final = "tests/integration"
_assert_collected(_collect_without_injected_pythonpath(target), target)