From 77c2ac18bd88ee89ae256fb627d4bc14aa5bb492 Mon Sep 17 00:00:00 2001 From: yuneng-jiang Date: Sat, 17 Oct 2026 14:00:03 -0700 Subject: [PATCH] test(caching): assert sync cache-hit logging without depending on thread order (#47093) Sync success callbacks run on a thread pool, so the miss and the two hits can reach the logger in any order. Compare counts instead of the list order. --- tests/unit/caching/test_caching_handler.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/unit/caching/test_caching_handler.py b/tests/unit/caching/test_caching_handler.py index 388e4c42ea0..51754c80dd6 100644 --- a/tests/unit/caching/test_caching_handler.py +++ b/tests/unit/caching/test_caching_handler.py @@ -42,6 +42,7 @@ from litellm.types.utils import ( Embedding, ) from litellm.types.llms.openai import ResponsesAPIResponse +from collections import Counter from collections.abc import Awaitable, Callable, Mapping from datetime import timedelta, datetime from typing import Final, cast @@ -104,7 +105,7 @@ def test_sync_cache_hits_reach_sync_custom_logger( call(**request_kwargs) assert all_logged.wait(timeout=10) - assert logged_cache_hits == [None, True, True] + assert Counter(logged_cache_hits) == Counter({None: 1, True: 2}), logged_cache_hits @pytest.fixture