scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-12 23:01:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 88

fix: drop adaptive_routers.clear() per Greptile review

Browse source 
adaptive_routers uses `continue` (not raise ValueError) for
duplicates, and its init is deferred to _finalize_adaptive_router_if_configured
which is only called from set_model_list, not the upsert_deployment path used
by clear_cache. Clearing it would lose routing preferences with no way to
restore them.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This commit is contained in:
unknown 2026-07-01 04:21:50 +00:00
parent 5094645a82
commit 75dd9ee4d2
2 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
litellm/proxy/management_endpoints/model_management_endpoints.py
View file

@ -1715,11 +1715,9 @@ async def clear_cache():
for model_id in db_model_ids:
llm_router.delete_deployment(id=model_id)
# Clear all strategy routers so they are re-initialized from DB state
llm_router.auto_routers.clear()
llm_router.complexity_routers.clear()
llm_router.quality_routers.clear()
llm_router.adaptive_routers.clear()
# Reload only DB models
await proxy_config.add_deployment(prisma_client=prisma_client, proxy_logging_obj=proxy_logging_obj)

4
tests/test_litellm/proxy/management_endpoints/test_model_management_endpoints.py
View file

@ -463,8 +463,6 @@ class TestClearCache:
mock_router.complexity_routers.clear = MagicMock()
mock_router.quality_routers = MagicMock()
mock_router.quality_routers.clear = MagicMock()
mock_router.adaptive_routers = MagicMock()
mock_router.adaptive_routers.clear = MagicMock()
mock_config = MagicMock()
mock_config.add_deployment = AsyncMock(return_value=True)
@ -486,11 +484,9 @@ class TestClearCache:
mock_router.delete_deployment.assert_any_call(id="db-model-1")
mock_router.delete_deployment.assert_any_call(id="db-model-2")
# Should have cleared all strategy routers
mock_router.auto_routers.clear.assert_called_once()
mock_router.complexity_routers.clear.assert_called_once()
mock_router.quality_routers.clear.assert_called_once()
mock_router.adaptive_routers.clear.assert_called_once()
# Should have called add_deployment to reload DB models
mock_config.add_deployment.assert_called_once_with(