From 75d61fa29779195de0fa6936e68806794a20d738 Mon Sep 17 00:00:00 2001 From: mateo-berri <277851410+mateo-berri@users.noreply.github.com> Date: Fri, 6 Nov 2026 07:30:16 -0800 Subject: [PATCH] fix(deepseek): leave malformed turns untouched when filling empty thinking blocks --- litellm/llms/deepseek/messages/transformation.py | 4 ++++ ...st_deepseek_anthropic_messages_transformation.py | 13 +++++++++++++ 2 files changed, 17 insertions(+) diff --git a/litellm/llms/deepseek/messages/transformation.py b/litellm/llms/deepseek/messages/transformation.py index 2ce97324cfb..4281ea9876a 100644 --- a/litellm/llms/deepseek/messages/transformation.py +++ b/litellm/llms/deepseek/messages/transformation.py @@ -36,11 +36,15 @@ def _sanitized_tool(tool: object) -> object: def _tool_turn_with_empty_thinking(message: object) -> Mapping[object, object] | None: + if not isinstance(message, dict): + return None fields: Final = _OBJECT_FIELDS.validate_python(message) content: Final = fields.get("content") if not isinstance(content, list): return None blocks: Final = _OBJECT_LIST.validate_python(content) + if not all(isinstance(block, dict) for block in blocks): + return None block_types: Final = frozenset(_OBJECT_FIELDS.validate_python(block).get("type") for block in blocks) if "tool_use" not in block_types or not block_types.isdisjoint(_THINKING_BLOCK_TYPES): return None diff --git a/tests/unit/llms/deepseek/messages/test_deepseek_anthropic_messages_transformation.py b/tests/unit/llms/deepseek/messages/test_deepseek_anthropic_messages_transformation.py index 3feed561a58..c6d3748ad42 100644 --- a/tests/unit/llms/deepseek/messages/test_deepseek_anthropic_messages_transformation.py +++ b/tests/unit/llms/deepseek/messages/test_deepseek_anthropic_messages_transformation.py @@ -264,3 +264,16 @@ def test_deepseek_anthropic_messages_leaves_history_alone_when_thinking_disabled request = _transform(_tool_loop_history(), {"thinking": {"type": "disabled"}}) assert request["messages"] == _tool_loop_history() + + +def test_deepseek_anthropic_messages_passes_malformed_turns_through_unchanged(): + malformed_turn = { + "role": "assistant", + "content": [{"type": "tool_use", "id": "toolu_1", "name": "bash", "input": {"command": "ls"}}, "oops"], + } + tail = _tool_loop_history()[8:] + + request = _transform(["hello", malformed_turn, *tail], {}) + + filled_turn = {**tail[1], "content": [{"type": "thinking", "thinking": ""}, *tail[1]["content"]]} + assert request["messages"] == ["hello", malformed_turn, tail[0], filled_turn, tail[2]]