test(mcp): cover post-call logging fallback paths

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This commit is contained in:
Devin AI 2026-09-18 22:49:42 +00:00
parent 06510d892f
commit 752abf954d

View file

@ -533,6 +533,80 @@ async def test_execute_tool_calls_applies_post_call_hook_content(monkeypatch):
assert logging_obj.async_success_handler.await_args.kwargs["result"].structuredContent is None
@pytest.mark.asyncio
async def test_execute_tool_calls_returns_proxy_result_without_logging(monkeypatch):
result = CallToolResult(content=[TextContent(type="text", text="ok")], isError=False)
proxy_logging_obj = MagicMock()
proxy_logging_obj.post_mcp_call_hook = AsyncMock(side_effect=lambda response, **_: response)
monkeypatch.setitem(
sys.modules, "litellm.proxy.proxy_server", types.SimpleNamespace(proxy_logging_obj=proxy_logging_obj)
)
fake_manager = types.SimpleNamespace(
get_registry=MagicMock(return_value={}),
call_tool=AsyncMock(return_value=result),
_get_mcp_server_from_tool_name=MagicMock(return_value=None),
get_mcp_server_by_name=MagicMock(return_value=None),
)
monkeypatch.setattr(
"litellm.proxy._experimental.mcp_server.mcp_server_manager.global_mcp_server_manager",
fake_manager,
)
handler_module = importlib.import_module("litellm.responses.mcp.litellm_proxy_mcp_handler")
monkeypatch.setattr(handler_module, "function_setup", lambda *_args, **_kwargs: (None, None))
tool_name = "deepwiki-read_wiki_structure"
results = await LiteLLM_Proxy_MCP_Handler._execute_tool_calls(
tool_server_map={tool_name: "deepwiki"},
tool_calls=[{"id": "call-1", "function": {"name": tool_name, "arguments": "{}"}}],
user_api_key_auth=None,
)
assert results == [{"tool_call_id": "call-1", "result": "ok", "name": tool_name}]
proxy_logging_obj.post_mcp_call_hook.assert_awaited_once()
@pytest.mark.asyncio
@pytest.mark.parametrize("failure_stage", ["post_call_hook", "success_handler"])
async def test_execute_tool_calls_continues_when_post_call_logging_fails(monkeypatch, failure_stage: str):
proxy_module = types.SimpleNamespace(proxy_logging_obj=None)
monkeypatch.setitem(sys.modules, "litellm.proxy.proxy_server", proxy_module)
result = CallToolResult(content=[TextContent(type="text", text="ok")], isError=False)
fake_manager = types.SimpleNamespace(
get_registry=MagicMock(return_value={}),
call_tool=AsyncMock(return_value=result),
_get_mcp_server_from_tool_name=MagicMock(return_value=None),
get_mcp_server_by_name=MagicMock(return_value=None),
)
monkeypatch.setattr(
"litellm.proxy._experimental.mcp_server.mcp_server_manager.global_mcp_server_manager",
fake_manager,
)
logging_obj = MagicMock()
logging_obj.model_call_details = {}
logging_obj.post_call = MagicMock()
logging_obj.async_post_mcp_tool_call_hook = AsyncMock(
side_effect=RuntimeError("hook failed") if failure_stage == "post_call_hook" else None,
return_value=result.content,
)
logging_obj.async_success_handler = AsyncMock(
side_effect=RuntimeError("success logging failed") if failure_stage == "success_handler" else None
)
handler_module = importlib.import_module("litellm.responses.mcp.litellm_proxy_mcp_handler")
monkeypatch.setattr(handler_module, "function_setup", lambda *_args, **_kwargs: (logging_obj, None))
tool_name = "deepwiki-read_wiki_structure"
results = await LiteLLM_Proxy_MCP_Handler._execute_tool_calls(
tool_server_map={tool_name: "deepwiki"},
tool_calls=[{"id": "call-1", "function": {"name": tool_name, "arguments": "{}"}}],
user_api_key_auth=None,
)
assert results == [{"tool_call_id": "call-1", "result": "ok", "name": tool_name}]
@pytest.mark.asyncio
async def test_get_mcp_tools_from_manager_enables_list_tools_logging(monkeypatch):
"""