From 74de09f2d302b6a6687a70c9f284f7a6c67a40d4 Mon Sep 17 00:00:00 2001 From: Alexsander Hamir Date: Mon, 26 Jan 2026 10:37:14 -0800 Subject: [PATCH] fix: patch base_llm_http_handler method directly in container tests - Use patch.object to patch container_create_handler method directly on the base_llm_http_handler instance instead of patching the module - Fixes test_provider_support[openai] failure where mock wasn't applied - Also fixes test_error_handling_integration with same approach The issue was that patching 'litellm.containers.main.base_llm_http_handler' didn't work because the module imports it with 'from litellm.main import', creating a local reference. Using patch.object patches the method on the actual object instance, which works regardless of import style. --- .../containers/test_container_integration.py | 22 +++++++++---------- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/tests/test_litellm/containers/test_container_integration.py b/tests/test_litellm/containers/test_container_integration.py index e83ae921c19..ee61e2f54ad 100644 --- a/tests/test_litellm/containers/test_container_integration.py +++ b/tests/test_litellm/containers/test_container_integration.py @@ -357,15 +357,15 @@ class TestContainerIntegration: def test_error_handling_integration(self): """Test error handling in the integration flow.""" - with patch('litellm.containers.main.base_llm_http_handler') as mock_handler: - # Simulate an API error - mock_handler.container_create_handler.side_effect = litellm.APIError( - status_code=400, - message="API Error occurred", - llm_provider="openai", - model="" - ) - + # Simulate an API error + api_error = litellm.APIError( + status_code=400, + message="API Error occurred", + llm_provider="openai", + model="" + ) + + with patch.object(litellm.main.base_llm_http_handler, 'container_create_handler', side_effect=api_error): with pytest.raises(litellm.APIError): create_container( name="Error Test Container", @@ -385,9 +385,7 @@ class TestContainerIntegration: name="Provider Test Container" ) - with patch('litellm.containers.main.base_llm_http_handler') as mock_handler: - mock_handler.container_create_handler.return_value = mock_response - + with patch.object(litellm.main.base_llm_http_handler, 'container_create_handler', return_value=mock_response): response = create_container( name="Provider Test Container", custom_llm_provider=provider