scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-19 00:01:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 88

fix(router): address final Greptile P1/P2 comments

Browse source 
- Reorder team_public_model_name assignment to happen before model_name mutation for clarity
- Add comment explaining no-rename fast-exit case in _update_existing_team_model_assignment
- Add comment explaining final patch_data.model_name = None applies to all code paths

Made-with: Cursor
This commit is contained in:
Sameer Kankute 2026-03-24 20:34:12 +05:30
parent 2321d77599
commit 7436f889ca
No known key found for this signature in database
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
litellm/proxy/management_endpoints/model_management_endpoints.py
View file

@ -329,17 +329,19 @@ async def _add_team_model_to_db(
_team_id = model_params.model_info.team_id
if _team_id is None:
return None
# Capture the original public name before mutating model_params.model_name
# Capture the original public name FIRST, before any mutations
original_model_name = model_params.model_name
# Generate unique internal model_name for team-scoped deployment
unique_model_name = f"model_name_{_team_id}_{uuid.uuid4()}"
# Store public name in model_info BEFORE overwriting model_name
# so _add_model_to_db serializes the correct team_public_model_name
# Set team_public_model_name in model_info using the captured original_model_name
# This must happen BEFORE mutating model_params.model_name so _add_model_to_db
# serializes the correct team_public_model_name (not the internal UUID name)
if original_model_name:
model_params.model_info.team_public_model_name = original_model_name
# Generate and assign unique internal model_name LAST
# (after team_public_model_name is safely stored)
unique_model_name = f"model_name_{_team_id}_{uuid.uuid4()}"
model_params.model_name = unique_model_name
## CREATE MODEL IN DB ##
@ -571,7 +573,11 @@ async def _update_existing_team_model_assignment(
http_request=Request(scope={"type": "http"}),
user_api_key_dict=user_api_key_dict,
)
# else: old_public_name == public_model_name (no rename needed)
# No team_model_add/delete calls required; public name is already registered
# Always clear patch_data.model_name to prevent caller from overwriting
# the internal UUID-based model_name in the DB with the user-supplied public name
patch_data.model_name = None