diff --git a/litellm-proxy-extras/litellm_proxy_extras/migrations/20261105000000_add_daily_usage_alerts/migration.sql b/litellm-proxy-extras/litellm_proxy_extras/migrations/20261105000000_add_daily_usage_alerts/migration.sql index 99173d137ea..f01406ae385 100644 --- a/litellm-proxy-extras/litellm_proxy_extras/migrations/20261105000000_add_daily_usage_alerts/migration.sql +++ b/litellm-proxy-extras/litellm_proxy_extras/migrations/20261105000000_add_daily_usage_alerts/migration.sql @@ -1,3 +1,5 @@ +SET LOCAL lock_timeout = '10s'; + CREATE TABLE IF NOT EXISTS "LiteLLM_UsageAlertRule" ( "id" TEXT PRIMARY KEY, "scope_type" TEXT NOT NULL, "scope_id" TEXT, "enabled" BOOLEAN NOT NULL DEFAULT true, "record" JSONB NOT NULL, diff --git a/litellm-proxy-extras/litellm_proxy_extras/migrations/20261105200000_issues_inbox/migration.sql b/litellm-proxy-extras/litellm_proxy_extras/migrations/20261105200000_issues_inbox/migration.sql index f5bb7799d79..6afa8f18a0e 100644 --- a/litellm-proxy-extras/litellm_proxy_extras/migrations/20261105200000_issues_inbox/migration.sql +++ b/litellm-proxy-extras/litellm_proxy_extras/migrations/20261105200000_issues_inbox/migration.sql @@ -1,3 +1,5 @@ +SET LOCAL lock_timeout = '10s'; + CREATE TABLE IF NOT EXISTS "LiteLLM_Issue" ( "id" TEXT NOT NULL, "cohort_key" TEXT NOT NULL, diff --git a/litellm/repositories/issues.py b/litellm/repositories/issues.py index 5bd0cc9c2aa..825c5f94a4d 100644 --- a/litellm/repositories/issues.py +++ b/litellm/repositories/issues.py @@ -529,7 +529,7 @@ class IssuesRepository: """WITH changed AS ( UPDATE "LiteLLM_Issue" SET active=false, status=CASE WHEN status='open' THEN 'resolved' ELSE status END,updated_at=CURRENT_TIMESTAMP - WHERE id=ANY($1::text[]) AND kind='performance' AND active AND last_seen<=$2::timestamp(3) + WHERE id=ANY($1::text[]) AND kind='performance' AND active AND last_seen<$2::timestamp(3) RETURNING id ) SELECT count(*)::int AS count FROM changed""", list(ids), diff --git a/tests/integration/database/test_issues.py b/tests/integration/database/test_issues.py index cde6cf84880..e5457867b07 100644 --- a/tests/integration/database/test_issues.py +++ b/tests/integration/database/test_issues.py @@ -1067,7 +1067,15 @@ async def test_provider_recovery_pages_saved_cohorts_and_rejects_stale_observati assert first[0].id == inputs[0].id and second[0].id == inputs[1].id assert await store.set_status(inputs[0].id, "dismissed", "open") is not None assert await store.recover_issue_ids((inputs[0].id,), template.observed_at - timedelta(seconds=1)) == 0 - assert await store.recover_issue_ids((inputs[0].id, inputs[1].id), template.observed_at) == 2 + assert await store.recover_issue_ids((inputs[0].id, inputs[1].id), template.observed_at) == 0, ( + "A recovery at the last observed timestamp must not close the alert" + ) + assert ( + await store.recover_issue_ids( + (inputs[0].id, inputs[1].id), template.observed_at + timedelta(milliseconds=1) + ) + == 2 + ) dismissed: Final = await store.get_issue(inputs[0].id) resolved: Final = await store.get_issue(inputs[1].id) assert dismissed is not None and not dismissed.active and dismissed.status == "dismissed"