fix(mock_completion): use mock response when mock_response is empty string (#48162)

This commit is contained in:
ANISAYAK MITRA 2026-10-24 13:17:02 +05:30
parent e04e89c701
commit 7356d096e9
3 changed files with 55 additions and 2 deletions

View file

@ -6027,7 +6027,11 @@ def completion(
custom_llm_provider=custom_llm_provider,
model_id=optional_params.get("model_id"),
)
if mock_response or mock_tool_calls or mock_timeout:
if should_run_mock_completion(
mock_response=mock_response,
mock_tool_calls=mock_tool_calls,
mock_timeout=mock_timeout,
):
kwargs.pop("mock_timeout", None) # remove for any fallbacks triggered
return mock_completion(
model,

View file

@ -11102,7 +11102,7 @@ def should_run_mock_completion(
mock_tool_calls: object | None,
mock_timeout: object | None,
) -> bool:
if mock_response or mock_tool_calls or mock_timeout:
if mock_response is not None or mock_tool_calls or mock_timeout:
return True
return False

View file

@ -0,0 +1,49 @@
import pytest
import litellm
from litellm.utils import should_run_mock_completion
def test_should_run_mock_completion_with_empty_string():
assert (
should_run_mock_completion(
mock_response="", mock_tool_calls=None, mock_timeout=None
)
is True
)
assert (
should_run_mock_completion(
mock_response=None, mock_tool_calls=None, mock_timeout=None
)
is False
)
assert (
should_run_mock_completion(
mock_response="test", mock_tool_calls=None, mock_timeout=None
)
is True
)
def test_completion_mock_response_empty_string():
response = litellm.completion(
model="openai/gpt-4o-mini",
messages=[{"role": "user", "content": "hi"}],
mock_response="",
api_base="http://127.0.0.1:9",
api_key="sk-test",
num_retries=0,
)
assert response.choices[0].message.content == ""
@pytest.mark.asyncio
async def test_acompletion_mock_response_empty_string():
response = await litellm.acompletion(
model="openai/gpt-4o-mini",
messages=[{"role": "user", "content": "hi"}],
mock_response="",
api_base="http://127.0.0.1:9",
api_key="sk-test",
num_retries=0,
)
assert response.choices[0].message.content == ""