scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-07 02:59:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 103

fix(test): use patch.object for reliable module attribute patching in cold storage test

Browse source 
The test was using patch('litellm.cold_storage_custom_logger', return_value='s3')
which creates a MagicMock object. While this works in most environments,
it can behave inconsistently in certain CI environments.

Changed to patch.object(litellm, 'cold_storage_custom_logger', 's3') which
directly sets the attribute value and ensures consistent behavior across
all test environments.

Fixes test_should_check_cold_storage_for_full_payload in litellm_mapped_tests_core
This commit is contained in:
Shin 2026-02-01 23:01:53 +00:00
parent df387c39f6
commit 71d77c489b
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/test_litellm/responses/litellm_completion_transformation/test_session_handler.py
View file

@ -343,7 +343,9 @@ async def test_should_check_cold_storage_for_full_payload():
# Test case 4: None request (should return True)
proxy_request_none = None
with patch("litellm.cold_storage_custom_logger", return_value="s3"):
# Use patch.object to properly set the attribute value (not a mock)
# This ensures consistent behavior across all test environments
with patch.object(litellm, 'cold_storage_custom_logger', 's3'):
# Test case 1: Should return True for truncated content
result1 = ResponsesSessionHandler._should_check_cold_storage_for_full_payload(proxy_request_with_truncated_pdf)
assert result1 == True, "Should return True for proxy request with truncated PDF content"