From 713a1a64b2dff29529d4af67aca4aef779a8ea78 Mon Sep 17 00:00:00 2001 From: Quinn Xu Date: Tue, 13 Oct 2026 10:13:54 -0700 Subject: [PATCH] fix(datadog): type-safe top-level model_name on LLMObs Meta Use required TypedDict key access for model / custom_llm_provider instead of str(.get(...)), so the basedpyright unknown-argument/member ceilings do not grow on this change. --- .../integrations/datadog/datadog_llm_obs.py | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/litellm/integrations/datadog/datadog_llm_obs.py b/litellm/integrations/datadog/datadog_llm_obs.py index 9ede440c9dc..4dcb40c7f8f 100644 --- a/litellm/integrations/datadog/datadog_llm_obs.py +++ b/litellm/integrations/datadog/datadog_llm_obs.py @@ -660,14 +660,11 @@ class DataDogLLMObsLogger(CustomBatchLogger): # Datadog prices llm/embedding spans from top-level meta.model_name / # model_provider. Those values already live in metadata; lift them so # embedding spans are not flagged "Partial cost — Unsupported model provider". - model_identity: Final[Meta] = ( - { - "model_name": str(standard_logging_payload.get("model") or "unknown"), - "model_provider": str(standard_logging_payload.get("custom_llm_provider") or "unknown"), - } - if span_kind in ("llm", "embedding") - else {} - ) + # Use TypedDict required-key access (not str(.get(...))) so basedpyright + # reportUnknownArgumentType / reportUnknownMemberType ceilings stay flat. + model_name: Final[str] = standard_logging_payload["model"] or "unknown" + provider_raw: Final[str | None] = standard_logging_payload["custom_llm_provider"] + model_provider: Final[str] = provider_raw if provider_raw is not None else "unknown" meta: Final[Meta] = { "kind": span_kind, "input": input_meta, @@ -675,7 +672,11 @@ class DataDogLLMObsLogger(CustomBatchLogger): "metadata": payload_metadata, "error": error_info, **({"tool_definitions": tool_definitions} if tool_definitions else {}), - **model_identity, + **( + {"model_name": model_name, "model_provider": model_provider} + if span_kind in ("llm", "embedding") + else {} + ), } metrics: Final = self._assemble_metrics(standard_logging_payload, tool_output_tokens)