mirror of
https://github.com/BerriAI/litellm.git
synced 2026-10-06 02:48:13 +00:00
fix(jwt-auth): apply team TPM/RPM + attribution for admins using x-litellm-team-id
Scope the header-driven team fetch to LLM API routes so admin management routes keep the pre-existing bypass behavior (no phantom teams, no 404s on mgmt calls). Team context is threaded onto UserAPIKeyAuth so spend logs, rate limits, and team_models attribution are correctly applied when admins act on behalf of a team via x-litellm-team-id.
This commit is contained in:
parent
8e652d129d
commit
6ea95a6379
3 changed files with 205 additions and 0 deletions
|
|
@ -45,6 +45,7 @@ from litellm.proxy._types import (
|
|||
UserAPIKeyAuth,
|
||||
)
|
||||
from litellm.proxy.auth.auth_checks import can_team_access_model
|
||||
from litellm.proxy.auth.route_checks import RouteChecks
|
||||
from litellm.proxy.utils import PrismaClient, ProxyLogging
|
||||
|
||||
from .auth_checks import (
|
||||
|
|
@ -1493,6 +1494,25 @@ class JWTAuthManager:
|
|||
jwt_handler, scopes, route, user_id, org_id, api_key, jwt_valid_token
|
||||
)
|
||||
if admin_result:
|
||||
# When an admin explicitly acts on behalf of a team via
|
||||
# x-litellm-team-id on an LLM API route, fetch the team so
|
||||
# team TPM/RPM limits and attribution apply. For admin
|
||||
# management routes we intentionally ignore the header to
|
||||
# preserve the pre-existing bypass behavior.
|
||||
header_team_id = (
|
||||
request_headers.get("x-litellm-team-id") if request_headers else None
|
||||
)
|
||||
if header_team_id and RouteChecks.is_llm_api_route(route=route):
|
||||
team_object = await get_team_object(
|
||||
team_id=header_team_id,
|
||||
prisma_client=prisma_client,
|
||||
user_api_key_cache=user_api_key_cache,
|
||||
parent_otel_span=parent_otel_span,
|
||||
proxy_logging_obj=proxy_logging_obj,
|
||||
team_id_upsert=jwt_handler.litellm_jwtauth.team_id_upsert,
|
||||
)
|
||||
admin_result["team_id"] = header_team_id
|
||||
admin_result["team_object"] = team_object
|
||||
return admin_result
|
||||
|
||||
# Get team with model access
|
||||
|
|
|
|||
|
|
@ -810,6 +810,21 @@ async def _user_api_key_auth_builder( # noqa: PLR0915
|
|||
if team_object is not None
|
||||
else None
|
||||
),
|
||||
team_tpm_limit=(
|
||||
team_object.tpm_limit
|
||||
if team_object is not None
|
||||
else None
|
||||
),
|
||||
team_rpm_limit=(
|
||||
team_object.rpm_limit
|
||||
if team_object is not None
|
||||
else None
|
||||
),
|
||||
team_models=(
|
||||
team_object.models
|
||||
if team_object is not None
|
||||
else []
|
||||
),
|
||||
team_metadata=(
|
||||
team_object.metadata
|
||||
if team_object is not None
|
||||
|
|
|
|||
|
|
@ -1498,6 +1498,176 @@ async def test_auth_builder_uses_team_from_header_e2e():
|
|||
assert result["team_object"] == team_object
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_auth_builder_admin_on_llm_route_honors_team_header():
|
||||
"""JWT proxy_admin + x-litellm-team-id on an LLM API route -> team context is
|
||||
attached to the admin result so team TPM/RPM limits and attribution apply."""
|
||||
from litellm.caching import DualCache
|
||||
from litellm.proxy.utils import ProxyLogging
|
||||
|
||||
jwt_handler = JWTHandler()
|
||||
user_api_key_cache = DualCache()
|
||||
jwt_handler.update_environment(
|
||||
prisma_client=None,
|
||||
user_api_key_cache=user_api_key_cache,
|
||||
litellm_jwtauth=LiteLLM_JWTAuth(
|
||||
team_ids_jwt_field="groups",
|
||||
user_id_jwt_field="sub",
|
||||
admin_allowed_routes=[
|
||||
"management_routes",
|
||||
"info_routes",
|
||||
"openai_routes",
|
||||
],
|
||||
),
|
||||
)
|
||||
|
||||
team_object = LiteLLM_TeamTable(
|
||||
team_id="team-low", tpm_limit=100, rpm_limit=2
|
||||
)
|
||||
|
||||
with (
|
||||
patch.object(jwt_handler, "auth_jwt", new_callable=AsyncMock) as mock_auth_jwt,
|
||||
patch.object(JWTAuthManager, "check_rbac_role", new_callable=AsyncMock),
|
||||
patch.object(jwt_handler, "is_admin", return_value=True),
|
||||
patch(
|
||||
"litellm.proxy.auth.handle_jwt.get_team_object", new_callable=AsyncMock
|
||||
) as mock_get_team,
|
||||
):
|
||||
mock_auth_jwt.return_value = {
|
||||
"sub": "admin-user",
|
||||
"scope": "",
|
||||
"groups": [],
|
||||
}
|
||||
mock_get_team.return_value = team_object
|
||||
|
||||
result = await JWTAuthManager.auth_builder(
|
||||
api_key="jwt-token",
|
||||
jwt_handler=jwt_handler,
|
||||
request_data={"model": "gpt-4"},
|
||||
general_settings={},
|
||||
route="/chat/completions",
|
||||
prisma_client=None,
|
||||
user_api_key_cache=user_api_key_cache,
|
||||
parent_otel_span=None,
|
||||
proxy_logging_obj=ProxyLogging(user_api_key_cache=user_api_key_cache),
|
||||
request_headers={"x-litellm-team-id": "team-low"},
|
||||
)
|
||||
|
||||
assert result["is_proxy_admin"] is True
|
||||
assert result["team_id"] == "team-low"
|
||||
assert result["team_object"] == team_object
|
||||
mock_get_team.assert_called_once()
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_auth_builder_admin_on_mgmt_route_ignores_team_header():
|
||||
"""JWT proxy_admin + x-litellm-team-id on an admin management route -> header
|
||||
is ignored; no team fetch. Preserves pre-existing bypass behavior and avoids
|
||||
phantom team creation when team_id_upsert is enabled."""
|
||||
from litellm.caching import DualCache
|
||||
from litellm.proxy.utils import ProxyLogging
|
||||
|
||||
jwt_handler = JWTHandler()
|
||||
user_api_key_cache = DualCache()
|
||||
jwt_handler.update_environment(
|
||||
prisma_client=None,
|
||||
user_api_key_cache=user_api_key_cache,
|
||||
litellm_jwtauth=LiteLLM_JWTAuth(
|
||||
team_ids_jwt_field="groups",
|
||||
user_id_jwt_field="sub",
|
||||
team_id_upsert=True,
|
||||
),
|
||||
)
|
||||
|
||||
with (
|
||||
patch.object(jwt_handler, "auth_jwt", new_callable=AsyncMock) as mock_auth_jwt,
|
||||
patch.object(JWTAuthManager, "check_rbac_role", new_callable=AsyncMock),
|
||||
patch.object(jwt_handler, "is_admin", return_value=True),
|
||||
patch(
|
||||
"litellm.proxy.auth.handle_jwt.get_team_object", new_callable=AsyncMock
|
||||
) as mock_get_team,
|
||||
):
|
||||
mock_auth_jwt.return_value = {
|
||||
"sub": "admin-user",
|
||||
"scope": "",
|
||||
"groups": [],
|
||||
}
|
||||
|
||||
result = await JWTAuthManager.auth_builder(
|
||||
api_key="jwt-token",
|
||||
jwt_handler=jwt_handler,
|
||||
request_data={},
|
||||
general_settings={},
|
||||
route="/user/info",
|
||||
prisma_client=None,
|
||||
user_api_key_cache=user_api_key_cache,
|
||||
parent_otel_span=None,
|
||||
proxy_logging_obj=ProxyLogging(user_api_key_cache=user_api_key_cache),
|
||||
request_headers={"x-litellm-team-id": "totally-made-up-team"},
|
||||
)
|
||||
|
||||
assert result["is_proxy_admin"] is True
|
||||
assert result["team_id"] is None
|
||||
assert result["team_object"] is None
|
||||
mock_get_team.assert_not_called()
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_auth_builder_admin_on_llm_route_without_header_unchanged():
|
||||
"""JWT proxy_admin on an LLM API route without x-litellm-team-id -> no team
|
||||
context (team limits not applied, admin keeps unrestricted access)."""
|
||||
from litellm.caching import DualCache
|
||||
from litellm.proxy.utils import ProxyLogging
|
||||
|
||||
jwt_handler = JWTHandler()
|
||||
user_api_key_cache = DualCache()
|
||||
jwt_handler.update_environment(
|
||||
prisma_client=None,
|
||||
user_api_key_cache=user_api_key_cache,
|
||||
litellm_jwtauth=LiteLLM_JWTAuth(
|
||||
team_ids_jwt_field="groups",
|
||||
user_id_jwt_field="sub",
|
||||
admin_allowed_routes=[
|
||||
"management_routes",
|
||||
"info_routes",
|
||||
"openai_routes",
|
||||
],
|
||||
),
|
||||
)
|
||||
|
||||
with (
|
||||
patch.object(jwt_handler, "auth_jwt", new_callable=AsyncMock) as mock_auth_jwt,
|
||||
patch.object(JWTAuthManager, "check_rbac_role", new_callable=AsyncMock),
|
||||
patch.object(jwt_handler, "is_admin", return_value=True),
|
||||
patch(
|
||||
"litellm.proxy.auth.handle_jwt.get_team_object", new_callable=AsyncMock
|
||||
) as mock_get_team,
|
||||
):
|
||||
mock_auth_jwt.return_value = {
|
||||
"sub": "admin-user",
|
||||
"scope": "",
|
||||
"groups": [],
|
||||
}
|
||||
|
||||
result = await JWTAuthManager.auth_builder(
|
||||
api_key="jwt-token",
|
||||
jwt_handler=jwt_handler,
|
||||
request_data={"model": "gpt-4"},
|
||||
general_settings={},
|
||||
route="/chat/completions",
|
||||
prisma_client=None,
|
||||
user_api_key_cache=user_api_key_cache,
|
||||
parent_otel_span=None,
|
||||
proxy_logging_obj=ProxyLogging(user_api_key_cache=user_api_key_cache),
|
||||
request_headers={},
|
||||
)
|
||||
|
||||
assert result["is_proxy_admin"] is True
|
||||
assert result["team_id"] is None
|
||||
assert result["team_object"] is None
|
||||
mock_get_team.assert_not_called()
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_get_team_alias_with_nested_fields():
|
||||
"""
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue