scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-29 06:33:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 200

fix(decisions): catch ValidationError from validate_json in transform_decisions_response (#48660) (#48662)

Browse source
This commit is contained in:
Niraj Kumar 2026-10-28 06:02:05 +05:30 • committed by GitHub
parent 4ad5a003b1
commit 6e09664118
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
litellm/llms/base_llm/decisions/transformation.py
View file

@ -657,8 +657,8 @@ class BaseDecisionsConfig(ABC):
raw_response: httpx.Response,
request: DecisionsIRRequest,
) -> DecisionsIRResponse:
payload: Final[object] = _PAYLOAD_ADAPTER.validate_json(raw_response.content)
try:
payload: Final[object] = _PAYLOAD_ADAPTER.validate_json(raw_response.content)
return self.parse_response(payload, request)
except ValidationError as error:
raise DecisionsResponseValidationError(

18
tests/unit/llms/base_llm/decisions/test_base_decisions_transformation.py
View file

@ -401,3 +401,21 @@ def test_score_probabilities_preserve_missing_entries_and_explicit_zeros(
ir_to_systemone_response(response, ir).model_dump(mode="json")["answers"]["score"]["probabilities"]
== probabilities
)
@pytest.mark.parametrize("raw_content", (b"", b"not-json", b'{"answers":'))
@pytest.mark.parametrize("provider", ("nace", "openrouter", "fireworks_ai", "typesafe", "openai"))
def test_non_json_provider_response_is_an_api_error(raw_content: bytes, provider: str) -> None:
config: Final = ProviderConfigManager.get_provider_decisions_config("drex-v2.0", LlmProviders(provider))
assert config is not None
request: Final = systemone_request_to_ir(
DecisionsRequestBody.model_validate(
{
"state": "text",
"questions": {"a": {"type": "score", "criteria": ["low", "high"]}},
}
)
)
with pytest.raises(BaseLLMException, match="unexpected response") as error:
config.transform_decisions_response("drex-v2.0", provider, httpx.Response(200, content=raw_content), request)
assert error.value.status_code == 500