scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-10 03:28:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 85

refactor: drop the unused response argument from the image item extractor

Browse source 
The image generation item ID no longer comes from the chat completion
response, so the extractor does not need it.
This commit is contained in:
mateo-berri 2026-08-22 14:22:08 -07:00
parent 6d2b7db2fb
commit 6a55683cd0
2 changed files with 0 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
litellm/responses/litellm_completion_transformation/transformation.py
View file

@ -2039,7 +2039,6 @@ class LiteLLMCompletionResponsesConfig:
@staticmethod
def _extract_image_generation_output_items(
chat_completion_response: ModelResponse,
choice: Choices,
) -> list[OutputImageGenerationCall]:
"""
@ -2142,7 +2141,6 @@ class LiteLLMCompletionResponsesConfig:
if hasattr(choice.message, "images") and choice.message.images:
# Extract image generation output
image_generation_items = LiteLLMCompletionResponsesConfig._extract_image_generation_output_items(
chat_completion_response=chat_completion_response,
choice=choice,
)
message_output_items.extend(image_generation_items)

17
tests/test_litellm/responses/litellm_completion_transformation/test_image_generation_output.py
View file

@ -57,9 +57,6 @@ class TestExtractImageGenerationOutputItems:
def test_extracts_images_correctly(self):
"""Should extract OutputImageGenerationCall objects from images"""
mock_response = Mock(spec=ModelResponse)
mock_response.id = "test_123"
mock_message = Mock(spec=Message)
mock_message.images = [
{
@ -80,7 +77,6 @@ class TestExtractImageGenerationOutputItems:
result = (
LiteLLMCompletionResponsesConfig._extract_image_generation_output_items(
chat_completion_response=mock_response,
choice=mock_choice,
)
)
@ -96,7 +92,6 @@ class TestExtractImageGenerationOutputItems:
def test_returns_empty_for_no_images(self):
"""Should return empty list if no images"""
mock_response = Mock(spec=ModelResponse)
mock_message = Mock(spec=Message)
mock_message.images = []
@ -106,7 +101,6 @@ class TestExtractImageGenerationOutputItems:
result = (
LiteLLMCompletionResponsesConfig._extract_image_generation_output_items(
chat_completion_response=mock_response,
choice=mock_choice,
)
)
@ -115,9 +109,6 @@ class TestExtractImageGenerationOutputItems:
def test_maps_finish_reason_to_status(self):
"""Should correctly map finish_reason to status"""
mock_response = Mock(spec=ModelResponse)
mock_response.id = "test_finish"
mock_message = Mock(spec=Message)
mock_message.images = [
{
@ -133,7 +124,6 @@ class TestExtractImageGenerationOutputItems:
result = (
LiteLLMCompletionResponsesConfig._extract_image_generation_output_items(
chat_completion_response=mock_response,
choice=mock_choice,
)
)
@ -219,14 +209,8 @@ class TestImageGenerationOutputItemIds:
mock_choice.finish_reason = "stop"
return mock_choice
def _chat_completion_response(self):
mock_response = Mock(spec=ModelResponse)
mock_response.id = "chatcmpl-dfa2da3a-1586-4ff7-b64e-f59c692a5d11"
return mock_response
def test_image_generation_item_id_uses_ig_prefix(self):
result = LiteLLMCompletionResponsesConfig._extract_image_generation_output_items(
chat_completion_response=self._chat_completion_response(),
choice=self._choice_with_images(2),
)
@ -238,7 +222,6 @@ class TestImageGenerationOutputItemIds:
def test_image_generation_item_ids_are_unique(self):
result = LiteLLMCompletionResponsesConfig._extract_image_generation_output_items(
chat_completion_response=self._chat_completion_response(),
choice=self._choice_with_images(3),
)