From 65fb18b568aba946a2813f5fae0cd13e6d14398b Mon Sep 17 00:00:00 2001 From: shin-bot-litellm Date: Sat, 31 Jan 2026 12:45:21 -0800 Subject: [PATCH] fix(mypy): fix validate_tool_name return type signatures (#20184) Move ToolNameValidationResult class definition outside the fallback function and use consistent return type annotation to satisfy mypy. Files fixed: - proxy/_experimental/mcp_server/mcp_server_manager.py - proxy/management_endpoints/mcp_management_endpoints.py --- .../_experimental/mcp_server/mcp_server_manager.py | 12 +++++------- .../management_endpoints/mcp_management_endpoints.py | 12 +++++------- 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/litellm/proxy/_experimental/mcp_server/mcp_server_manager.py b/litellm/proxy/_experimental/mcp_server/mcp_server_manager.py index 5ae5b610805..d763b8fb644 100644 --- a/litellm/proxy/_experimental/mcp_server/mcp_server_manager.py +++ b/litellm/proxy/_experimental/mcp_server/mcp_server_manager.py @@ -70,16 +70,14 @@ try: validate_tool_name, ) except ImportError: - from typing import Any + from pydantic import BaseModel SEP_986_URL = "https://github.com/modelcontextprotocol/protocol/blob/main/proposals/0001-tool-name-validation.md" - def validate_tool_name(name: str) -> Any: - from pydantic import BaseModel - - class ToolNameValidationResult(BaseModel): - is_valid: bool = True - warnings: list = [] + class ToolNameValidationResult(BaseModel): + is_valid: bool = True + warnings: list = [] + def validate_tool_name(name: str) -> ToolNameValidationResult: return ToolNameValidationResult() diff --git a/litellm/proxy/management_endpoints/mcp_management_endpoints.py b/litellm/proxy/management_endpoints/mcp_management_endpoints.py index 3ba841f07fd..6225f39626d 100644 --- a/litellm/proxy/management_endpoints/mcp_management_endpoints.py +++ b/litellm/proxy/management_endpoints/mcp_management_endpoints.py @@ -63,15 +63,13 @@ if MCP_AVAILABLE: validate_tool_name, ) except ImportError: - from typing import Any + from pydantic import BaseModel - def validate_tool_name(name: str) -> Any: - from pydantic import BaseModel - - class ToolNameValidationResult(BaseModel): - is_valid: bool = True - warnings: list = [] + class ToolNameValidationResult(BaseModel): + is_valid: bool = True + warnings: list = [] + def validate_tool_name(name: str) -> ToolNameValidationResult: return ToolNameValidationResult() from litellm.proxy._experimental.mcp_server.db import (