From 64a186594da2b9aa666c90309779c2437d5ab3a9 Mon Sep 17 00:00:00 2001 From: Mrinal Chanshetty Date: Sat, 24 Oct 2026 20:38:12 -0500 Subject: [PATCH] refactor(ui): inline the one-team check for the Spend Per Tag card singleTeamId had one caller and its unit test repeated what EntityUsage.test.tsx already checks through the page, so the module and its test are removed. --- .../components/EntityUsage/EntityUsage.tsx | 3 +-- .../components/EntityUsage/teamTagSpend.test.ts | 11 ----------- .../components/EntityUsage/teamTagSpend.ts | 2 -- 3 files changed, 1 insertion(+), 15 deletions(-) delete mode 100644 ui/litellm-dashboard/src/app/(dashboard)/usage/_components/components/EntityUsage/teamTagSpend.test.ts delete mode 100644 ui/litellm-dashboard/src/app/(dashboard)/usage/_components/components/EntityUsage/teamTagSpend.ts diff --git a/ui/litellm-dashboard/src/app/(dashboard)/usage/_components/components/EntityUsage/EntityUsage.tsx b/ui/litellm-dashboard/src/app/(dashboard)/usage/_components/components/EntityUsage/EntityUsage.tsx index 197b1ab0229..de44d0523be 100644 --- a/ui/litellm-dashboard/src/app/(dashboard)/usage/_components/components/EntityUsage/EntityUsage.tsx +++ b/ui/litellm-dashboard/src/app/(dashboard)/usage/_components/components/EntityUsage/EntityUsage.tsx @@ -55,7 +55,6 @@ import { Panel, Segmented, Sparkline, Stat } from "../overview/Primitives"; import TopModelView from "./TopModelView"; import TeamTagSpendCard from "./TeamTagSpendCard"; import TeamUserSpendCard from "./TeamUserSpendCard"; -import { singleTeamId } from "./teamTagSpend"; import { ProviderSpendBreakdown } from "./SpendByProvider"; const BRAND = "#2b3fd6"; @@ -363,7 +362,7 @@ const EntityUsage: React.FC = ({ const filterSlot = entityFilterSlots[entityType]; const capitalizedEntityLabel = entityType.charAt(0).toUpperCase() + entityType.slice(1); - const tagSpendTeamId = entityType === "team" ? singleTeamId(selectedTags) : null; + const tagSpendTeamId = entityType === "team" && selectedTags.length === 1 ? selectedTags[0] : null; const showFlatCost = entityType === "team" && hasFlatCost(spendData.metadata); const showPtuHours = entityType === "team" && hasPtuHours(spendData.metadata); const userSpendTeamIds = useMemo( diff --git a/ui/litellm-dashboard/src/app/(dashboard)/usage/_components/components/EntityUsage/teamTagSpend.test.ts b/ui/litellm-dashboard/src/app/(dashboard)/usage/_components/components/EntityUsage/teamTagSpend.test.ts deleted file mode 100644 index 329845b0f08..00000000000 --- a/ui/litellm-dashboard/src/app/(dashboard)/usage/_components/components/EntityUsage/teamTagSpend.test.ts +++ /dev/null @@ -1,11 +0,0 @@ -import { describe, expect, it } from "vitest"; - -import { singleTeamId } from "./teamTagSpend"; - -describe("singleTeamId", () => { - it("is the team only when exactly one is selected", () => { - expect(singleTeamId(["team-a"])).toBe("team-a"); - expect(singleTeamId([])).toBeNull(); - expect(singleTeamId(["team-a", "team-b"])).toBeNull(); - }); -}); diff --git a/ui/litellm-dashboard/src/app/(dashboard)/usage/_components/components/EntityUsage/teamTagSpend.ts b/ui/litellm-dashboard/src/app/(dashboard)/usage/_components/components/EntityUsage/teamTagSpend.ts deleted file mode 100644 index c160bf77d0a..00000000000 --- a/ui/litellm-dashboard/src/app/(dashboard)/usage/_components/components/EntityUsage/teamTagSpend.ts +++ /dev/null @@ -1,2 +0,0 @@ -export const singleTeamId = (selectedTeamIds: readonly string[]): string | null => - selectedTeamIds.length === 1 ? selectedTeamIds[0] : null;