fix: address Greptile review feedback

- Clean up aliases key from entries with empty aliases list
- Strengthen test assertion for alias conflict warning
This commit is contained in:
Chesars 2026-03-10 16:09:49 -03:00
parent 7ccb14cab4
commit 6469de9516
2 changed files with 4 additions and 2 deletions

View file

@ -199,9 +199,11 @@ def _expand_model_aliases(model_cost: dict) -> dict:
for model_name, model_info in model_cost.items():
aliases: Optional[list] = model_info.get("aliases")
if not aliases:
if aliases is None:
continue
keys_with_aliases.append(model_name)
if not aliases:
continue
for alias in aliases:
if alias in model_cost:
verbose_logger.warning(

View file

@ -148,7 +148,7 @@ class TestAliasConflicts:
# The canonical "model-dated" entry is preserved, not overwritten
assert "model-dated" in result
assert "alias conflict" in caplog.text.lower() or len(result) == 2
assert "alias conflict" in caplog.text.lower()
def test_duplicate_alias_across_entries(self, caplog):
"""Same alias claimed by two different entries: second one is skipped."""