scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-11-12 08:42:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 207

test(logging): move the large-error scrub timing check to a CodSpeed benchmark

Browse source 
tests/unit/AGENTS.md forbids unit tests that depend on execution speed, so the four large errors now run as a benchmark that asserts the scrubbed output.
This commit is contained in:
yucheng 2026-11-04 16:57:29 -08:00
parent 1ebe49ca1a
commit 621b0dde97
2 changed files with 22 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
tests/benchmarks/test_redact_messages_benchmarks.py Normal file
View file

@ -0,0 +1,22 @@
from typing import Final
import pytest
from litellm.litellm_core_utils.redact_messages import request_texts, scrub_request_text
REQUEST_TEXTS: Final = request_texts("hi there")
@pytest.mark.benchmark
@pytest.mark.parametrize(
("error", "scrubbed"),
[
("." * 100_000, "." * 100_000),
(" ...'x" * 20_000, " ...'x" * 20_000),
("input_value=" * 10_000, "input_value=redacted-by-litellm"),
("input_value=x, input_type=y\n" * 4_000, "input_value=redacted-by-litellm, input_type=y\n" * 4_000),
],
ids=["dots", "quoted_cuts", "input_value_labels_on_one_line", "input_values_on_many_lines"],
)
def test_scrubbing_a_large_error(error: str, scrubbed: str) -> None:
assert scrub_request_text(error, REQUEST_TEXTS) == scrubbed

14
tests/unit/litellm_core_utils/test_redact_messages.py
View file

@ -11,7 +11,6 @@ import importlib
import json
import os
import threading
import time
import tracemalloc
from collections.abc import AsyncIterator, Callable, Mapping
from datetime import datetime
@ -2435,19 +2434,6 @@ def test_scrub_request_text_keeps_an_input_value_when_the_request_has_no_text()
assert scrub_request_text(error, request_texts(None)) == error
@pytest.mark.parametrize(
"error",
["." * 1_000_000, "input_value=" * 100_000, "input_value=x, input_type=y\n" * 40_000, " ...'x" * 200_000],
ids=["dots", "input_value_labels_on_one_line", "input_values_on_many_lines", "quoted_cuts"],
)
def test_scrub_request_text_stays_fast_on_a_large_error(error: str) -> None:
started: Final = time.perf_counter()
scrub_request_text(error, request_texts("hi there"))
assert time.perf_counter() - started < 0.5
def test_scrub_request_text_leaves_an_error_that_does_not_quote_the_prompt() -> None:
assert scrub_request_text("Incorrect API key provided", request_texts(PROMPT, "hi")) == "Incorrect API key provided"