scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-03 02:22:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 81

test(vector_stores): annotate locals Final and mutate registries through their public API

Browse source 
The leak tests now go through add_vector_store_to_registry and upsert_vector_store_index rather than appending to the registry's list directly, which is closer to how the proxy hits the bug.
This commit is contained in:
Priyansh Nandwana 2026-09-14 11:27:33 +05:30
parent 517bd79d65
commit 620f586dbb
1 changed files with 23 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
tests/unit/vector_stores/test_vector_store_registry.py
View file

@ -8,10 +8,15 @@ from fastapi.testclient import TestClient
from datetime import datetime, timezone
from typing import Final
from unittest.mock import AsyncMock, MagicMock
import litellm
from litellm.types.vector_stores import LiteLLM_ManagedVectorStore
from litellm.types.vector_stores import (
IndexCreateLiteLLMParams,
LiteLLM_ManagedVectorStore,
LiteLLM_ManagedVectorStoreIndex,
)
from litellm.vector_stores.main import search
from litellm.vector_stores.vector_store_registry import (
VectorStoreIndexRegistry,
@ -255,35 +260,38 @@ async def test_config_owned_store_survives_db_liveness_check_while_missing_db_st
class TestRegistriesDoNotShareDefaultState:
"""#38874: a mutable default argument made every default-constructed registry share
one list, so upserting into one polluted every other instance and the class default."""
"""#38874: default-constructed registries must not share one list."""
def test_vector_store_registries_do_not_share_a_list(self):
first = VectorStoreRegistry()
second = VectorStoreRegistry()
first: Final = VectorStoreRegistry()
second: Final = VectorStoreRegistry()
assert first.vector_stores is not second.vector_stores
def test_index_registries_do_not_share_a_list(self):
first = VectorStoreIndexRegistry()
second = VectorStoreIndexRegistry()
first: Final = VectorStoreIndexRegistry()
second: Final = VectorStoreIndexRegistry()
assert first.vector_store_indexes is not second.vector_store_indexes
def test_mutating_one_registry_leaves_the_next_one_empty(self):
first = VectorStoreRegistry()
first.vector_stores.append(
def test_adding_to_one_registry_leaves_the_next_one_empty(self):
VectorStoreRegistry().add_vector_store_to_registry(
LiteLLM_ManagedVectorStore(vector_store_id="vs-leak", custom_llm_provider="bedrock")
)
assert VectorStoreRegistry().vector_stores == []
def test_mutating_one_index_registry_leaves_the_next_one_empty(self):
first = VectorStoreIndexRegistry()
first.vector_store_indexes.append({"index_name": "leak"})
def test_upserting_into_one_index_registry_leaves_the_next_one_empty(self):
VectorStoreIndexRegistry().upsert_vector_store_index(
LiteLLM_ManagedVectorStoreIndex(
id="idx-leak",
index_name="leak",
litellm_params=IndexCreateLiteLLMParams(vector_store_index="vs-leak", vector_store_name="leak"),
)
)
assert VectorStoreIndexRegistry().get_vector_store_indexes() == []
def test_a_supplied_list_is_still_used_as_given(self):
supplied = [LiteLLM_ManagedVectorStore(vector_store_id="vs-1", custom_llm_provider="bedrock")]
supplied: Final = [LiteLLM_ManagedVectorStore(vector_store_id="vs-1", custom_llm_provider="bedrock")]
assert VectorStoreRegistry(vector_stores=supplied).vector_stores is supplied
def test_a_supplied_empty_list_is_still_used_as_given(self):
supplied: list = []
supplied: Final[list[LiteLLM_ManagedVectorStore]] = []
assert VectorStoreRegistry(vector_stores=supplied).vector_stores is supplied