From 5fa1257b7c4c0719f78c43a6e71ef788834c3a28 Mon Sep 17 00:00:00 2001
From: "devin-ai-integration[bot]"
 <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Date: Wed, 23 Sep 2026 02:11:19 +0000
Subject: [PATCH] test(utils): raise the post-success hook error from a
 guardrail in the failure-hook regression (#42646)

* test(utils): raise the post-success hook error from a guardrail in the failure-hook regression

Since #42535 a plain logger raising inside async_post_call_success_deployment_hook
is logged and the completed request returns, so the regression added by #36657 for
"a post-success error never reaches async_post_call_failure_deployment_hook" failed
with DID NOT RAISE on every main run once #42603 revived the misc unit shard. The
raising callback is now a CustomGuardrail, the one kind of callback whose
post-success raise still propagates, which keeps the original assertions intact

* test(utils): type the guardrail's success-hook request_data as a Mapping

---------

Co-authored-by: mateo-berri <277851410+mateo-berri@users.noreply.github.com>
---
 tests/test_litellm/test_utils.py | 32 ++++++++++++++++++++------------
 1 file changed, 20 insertions(+), 12 deletions(-)

diff --git a/tests/test_litellm/test_utils.py b/tests/test_litellm/test_utils.py
index 89472cbd20f..ce280cc3513 100644
--- a/tests/test_litellm/test_utils.py
+++ b/tests/test_litellm/test_utils.py
@@ -8,7 +8,7 @@ import logging
 import os
 import queue
 import threading
-from collections.abc import Callable, Iterator
+from collections.abc import Callable, Iterator, Mapping
 from concurrent.futures import Future, ThreadPoolExecutor
 from datetime import datetime, timedelta, timezone
 from pathlib import PurePath
@@ -5283,23 +5283,31 @@ async def test_wrapper_async_does_not_fire_failure_hook_for_post_success_error(
 ) -> None:
     """Regression: an error raised after the deployment call already succeeded (e.g. inside
     async_post_call_success_deployment_hook or post_call_processing) is not a deployment
-    attempt failure and must not reach async_post_call_failure_deployment_hook."""
+    attempt failure and must not reach async_post_call_failure_deployment_hook. The raising
+    callback is a guardrail because a plain logger's success hook error is isolated and
+    logged instead of propagating out of the call."""
 
-    class ExplodingSuccessLogger(CustomLogger):
+    class ExplodingSuccessGuardrail(CustomGuardrail):
         def __init__(self) -> None:
-            super().__init__()
-            self.failure_calls: list[Exception] = []
+            super().__init__(guardrail_name="exploding")
+            self.failure_calls: tuple[Exception, ...] = ()
 
-        async def async_post_call_success_deployment_hook(self, request_data, response, call_type):
+        async def async_post_call_success_deployment_hook(
+            self, request_data: Mapping[str, object], response: LLMResponseTypes, call_type: CallTypes | None
+        ) -> LLMResponseTypes | None:
             raise RuntimeError("boom in success hook, model call itself succeeded")
 
         async def async_post_call_failure_deployment_hook(
-            self, request_data, exception, call_type, fallback_depth=None
-        ):
-            self.failure_calls.append(exception)
+            self,
+            request_data: Mapping[str, object],
+            exception: Exception,
+            call_type: CallTypes | None,
+            fallback_depth: int | None = None,
+        ) -> None:
+            self.failure_calls = (*self.failure_calls, exception)
 
-    exploding_logger = ExplodingSuccessLogger()
-    monkeypatch.setattr(litellm, "callbacks", [exploding_logger])
+    exploding_guardrail: Final = ExplodingSuccessGuardrail()
+    monkeypatch.setattr(litellm, "callbacks", [exploding_guardrail])
 
     with pytest.raises(RuntimeError, match="boom in success hook"):
         await litellm.acompletion(
@@ -5308,7 +5316,7 @@ async def test_wrapper_async_does_not_fire_failure_hook_for_post_success_error(
             mock_response="this call succeeds",
         )
 
-    assert exploding_logger.failure_calls == []
+    assert exploding_guardrail.failure_calls == ()
 
 
 @pytest.mark.asyncio