scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-29 01:42:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 79

fix(redis): guard missing async pool on shutdown

Browse source
This commit is contained in:
adhavan18 2026-09-24 14:11:57 +05:30
parent 518800cd57
commit 5e843bcfde
2 changed files with 29 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
litellm/caching/redis_cache.py
View file

@ -1785,7 +1785,8 @@ class RedisCache(BaseCache):
self.redis_client.flushall()
async def disconnect(self):
await self.async_redis_conn_pool.disconnect(inuse_connections=True)
if self.async_redis_conn_pool is not None:
await self.async_redis_conn_pool.disconnect(inuse_connections=True)
try:
self.redis_client.close()
except Exception as e:

27
tests/test_litellm/test_redis_disconnect.py Normal file
View file

@ -0,0 +1,27 @@
from unittest.mock import AsyncMock, Mock
import pytest
from litellm.caching.redis_cache import RedisCache
@pytest.mark.asyncio
async def test_disconnect_allows_missing_async_pool():
cache = RedisCache.__new__(RedisCache)
cache.async_redis_conn_pool = None
cache.redis_client = Mock()
await cache.disconnect()
cache.redis_client.close.assert_called_once_with()
@pytest.mark.asyncio
async def test_disconnect_closes_present_async_pool():
cache = RedisCache.__new__(RedisCache)
cache.async_redis_conn_pool = Mock(disconnect=AsyncMock())
cache.redis_client = Mock()
await cache.disconnect()
cache.async_redis_conn_pool.disconnect.assert_awaited_once_with(inuse_connections=True)