From 5d1fcf57e550f6473f6cfdb836656c8540862b95 Mon Sep 17 00:00:00 2001 From: Mrinal Chanshetty Date: Thu, 29 Oct 2026 09:48:50 -0700 Subject: [PATCH] fix(guardrails): build PANW kwargs without mutation and clean up DB-created test guardrails Restore main's single-expression kwargs in the PANW initializer. The two DB-backed integration tests now create their guardrail inside the scenario and delete it on exit. --- .../panw_prisma_airs/__init__.py | 14 ++-- .../test_panw_airs_block_masked_response.py | 75 ++++++++----------- 2 files changed, 40 insertions(+), 49 deletions(-) diff --git a/litellm/proxy/guardrails/guardrail_hooks/panw_prisma_airs/__init__.py b/litellm/proxy/guardrails/guardrail_hooks/panw_prisma_airs/__init__.py index 9e7199f88c5..2401012de32 100644 --- a/litellm/proxy/guardrails/guardrail_hooks/panw_prisma_airs/__init__.py +++ b/litellm/proxy/guardrails/guardrail_hooks/panw_prisma_airs/__init__.py @@ -17,12 +17,14 @@ def initialize_guardrail(litellm_params: "LitellmParams", guardrail: "Guardrail" if not guardrail_name: raise ValueError("PANW Prisma AIRS: guardrail_name is required") - litellm_params_dump: Final = litellm_params.model_dump(exclude_unset=True) - litellm_params_dump["guardrail_name"] = guardrail_name - litellm_params_dump["event_hook"] = litellm_params.mode - litellm_params_dump["default_on"] = litellm_params.default_on or False - - _panw_callback: Final = PanwPrismaAirsHandler(**litellm_params_dump) + _panw_callback: Final = PanwPrismaAirsHandler( + **{ + **litellm_params.model_dump(exclude_unset=True), + "guardrail_name": guardrail_name, + "event_hook": litellm_params.mode, + "default_on": litellm_params.default_on or False, + } + ) litellm.logging_callback_manager.add_litellm_callback(_panw_callback) return _panw_callback diff --git a/tests/integration/observability/test_panw_airs_block_masked_response.py b/tests/integration/observability/test_panw_airs_block_masked_response.py index b111507f520..1461685ecef 100644 --- a/tests/integration/observability/test_panw_airs_block_masked_response.py +++ b/tests/integration/observability/test_panw_airs_block_masked_response.py @@ -14,7 +14,7 @@ from typing import Final import pytest import yaml -from integration._support.client import Gateway, object_value +from integration._support.client import Gateway, Scenario, object_value, string_value from integration._support.process import owned_proxy from integration._support.wire import Reply, Request, wire_server from pydantic import JsonValue @@ -63,9 +63,7 @@ def _scanner(request: Request) -> Reply: contents: Final = json.loads(request.body)["contents"][0] if "response" in contents: return Reply(body=json.dumps(_block_scan()).encode()) - return Reply( - body=json.dumps({"action": "allow", "category": "benign", "response_detected": {}}).encode() - ) + return Reply(body=json.dumps({"action": "allow", "category": "benign", "response_detected": {}}).encode()) def _scanner_without_masked_data(request: Request) -> Reply: @@ -73,9 +71,7 @@ def _scanner_without_masked_data(request: Request) -> Reply: contents: Final = json.loads(request.body)["contents"][0] if "response" in contents: return Reply(body=json.dumps(_block_scan(with_masked_data=False)).encode()) - return Reply( - body=json.dumps({"action": "allow", "category": "benign", "response_detected": {}}).encode() - ) + return Reply(body=json.dumps({"action": "allow", "category": "benign", "response_detected": {}}).encode()) def _provider(request: Request) -> Reply: @@ -179,10 +175,7 @@ def _block_detail(node: JsonValue) -> Mapping[str, JsonValue] | None: def _response_scans(requests: tuple[Request, ...]) -> list[dict[str, JsonValue]]: return [ - contents - for request in requests - for contents in json.loads(request.body)["contents"] - if "response" in contents + contents for request in requests for contents in json.loads(request.body)["contents"] if "response" in contents ] @@ -194,6 +187,32 @@ def _request_body(model: str, target: str) -> dict[str, JsonValue]: return {"model": model, "messages": [{"role": "user", "content": "say hi"}]} +def _db_guardrail(scenario: Scenario, name: str, policy_url: str, include_masked_response_on_block: JsonValue) -> None: + created: Final = scenario.gateway.post( + "/guardrails", + { + "guardrail": { + "guardrail_name": name, + "litellm_params": { + "guardrail": "panw_prisma_airs", + "mode": "post_call", + "api_base": policy_url, + "api_key": "synthetic-panw-key", + "profile_name": "synthetic-profile", + "include_masked_response_on_block": include_masked_response_on_block, + }, + } + }, + ) + guardrail_id: Final = string_value(created["guardrail_id"]) + scenario.cleanups.callback(_delete_guardrail, scenario.gateway, guardrail_id) + + +def _delete_guardrail(gateway: Gateway, guardrail_id: str) -> None: + deleted: Final = gateway.request("DELETE", f"/guardrails/{guardrail_id}") + assert deleted.status_code == 200, deleted.text + + @pytest.mark.parametrize("target", ["/v1/chat/completions", "/v1/responses", "/v1/messages"]) def test_block_includes_response_masked_data_when_opted_in(gateway: Gateway, tmp_path: Path, target: str) -> None: identity: Final = "guardrail" + uuid.uuid4().hex @@ -280,23 +299,8 @@ def test_db_created_guardrail_string_false_withholds_response_masked_data_on_blo """The dashboard persists some litellm_params as strings; "false" must not turn the flag on.""" name: Final = f"panw-string-false-{uuid.uuid4().hex[:8]}" with wire_server(_scanner) as policy, wire_server(_provider) as upstream: - gateway.post( - "/guardrails", - { - "guardrail": { - "guardrail_name": name, - "litellm_params": { - "guardrail": "panw_prisma_airs", - "mode": "post_call", - "api_base": policy.url, - "api_key": "synthetic-panw-key", - "profile_name": "synthetic-profile", - "include_masked_response_on_block": "false", - }, - } - }, - ) with gateway.scenario() as scenario: + _db_guardrail(scenario, name, policy.url, "false") model: Final = scenario.model( model="openai/gpt-4.1-mini", api_base=upstream.url + "/v1", api_key="synthetic-key" ) @@ -316,23 +320,8 @@ def test_db_created_guardrail_string_false_withholds_response_masked_data_on_blo def test_db_created_guardrail_includes_response_masked_data_on_block(gateway: Gateway, tmp_path: Path) -> None: name: Final = f"panw-block-details-{uuid.uuid4().hex[:8]}" with wire_server(_scanner) as policy, wire_server(_provider) as upstream: - gateway.post( - "/guardrails", - { - "guardrail": { - "guardrail_name": name, - "litellm_params": { - "guardrail": "panw_prisma_airs", - "mode": "post_call", - "api_base": policy.url, - "api_key": "synthetic-panw-key", - "profile_name": "synthetic-profile", - "include_masked_response_on_block": True, - }, - } - }, - ) with gateway.scenario() as scenario: + _db_guardrail(scenario, name, policy.url, True) model: Final = scenario.model( model="openai/gpt-4.1-mini", api_base=upstream.url + "/v1", api_key="synthetic-key" )