From 5bad1a85f7f258267a19a9b6772cc4588920a566 Mon Sep 17 00:00:00 2001 From: ryan-crabbe-berri Date: Sat, 12 Sep 2026 20:27:37 -0700 Subject: [PATCH] ci(duplicate-check): only warn about the auto close the sweep will actually do The notice now asks the sweep's own duplicateTarget whether the title match would close the issue, so a two-word title no longer gets a close warning the sweep would refuse to act on. The ask no longer promises that a reply removes the label, since nothing does that automatically --- scripts/flag-duplicate-issue.test.ts | 11 +++++++++++ scripts/flag-duplicate-issue.ts | 8 ++++---- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/scripts/flag-duplicate-issue.test.ts b/scripts/flag-duplicate-issue.test.ts index fb946998fed..4f857e29e70 100644 --- a/scripts/flag-duplicate-issue.test.ts +++ b/scripts/flag-duplicate-issue.test.ts @@ -85,6 +85,17 @@ describe("noticeBody", () => { const closedTwin = issue(10, "[bug] gemma 4-e4b fails on vertex!", { state: "closed" }); expect(noticeBody(reporter, closedTwin, "Same stack.")).not.toContain("closes automatically"); expect(duplicateTarget(reporter, [closedTwin], []).kind).toBe("skip"); + + const short = issue(35, "[Bug]: Vertex crash"); + const shortTwin = issue(10, "Vertex crash"); + expect(noticeBody(short, shortTwin, "Same stack.")).not.toContain("closes automatically"); + expect(duplicateTarget(short, [shortTwin], []).kind).toBe("skip"); + }); + + test("never promises a label removal nothing performs", () => { + const body = noticeBody(reporter, issue(10, "Vertex Gemma 4 crash"), "Same stack."); + expect(body).toContain("a maintainer will take the label off"); + expect(body).not.toContain("the label comes off"); }); }); diff --git a/scripts/flag-duplicate-issue.ts b/scripts/flag-duplicate-issue.ts index 317efa61c80..f10bb625ec8 100644 --- a/scripts/flag-duplicate-issue.ts +++ b/scripts/flag-duplicate-issue.ts @@ -3,9 +3,9 @@ import { DEFAULT_GRACE_DAYS, FLAG_LABEL, + duplicateTarget, githubApi, listAll, - normalizeTitle, type Comment, type GitHubApi, type Issue, @@ -87,9 +87,9 @@ export function noticeBody(issue: Issue, prior: Issue, evidence: string): string ? `**Already reported in #${prior.number}**, which is closed` : `**Possible duplicate of #${prior.number}**`; const ask = closed - ? "If that issue covers this one, follow up there. If this is a new case, say so here and the label comes off." - : `If that is right, add a thumbs-up to #${prior.number} and follow along there. If it is not, say so here and the label comes off.`; - const autoCloses = !closed && normalizeTitle(issue.title) === normalizeTitle(prior.title); + ? "If that issue covers this one, follow up there. If this is a new case, say so here and a maintainer will take the label off." + : `If that is right, add a thumbs-up to #${prior.number} and follow along there. If it is not, say so here and a maintainer will take the label off.`; + const autoCloses = duplicateTarget(issue, [prior], []).kind === "close"; const warning = autoCloses ? `\n\nYour title is identical to #${prior.number}, so this issue closes automatically in ${DEFAULT_GRACE_DAYS} days unless someone responds here.` : "";