From 5af15a2b5996632d790c6bad626ee7f2970a99ea Mon Sep 17 00:00:00 2001 From: Praveen Ghuge Date: Sun, 26 Apr 2026 07:58:21 +0530 Subject: [PATCH] style(mavvrik): address pattern conformance findings 3 and 4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Finding 3 — proxy_server.py: remove inline `import os as _os` Every other integration block in _initialize_spend_tracking_background_jobs uses the module-level os import already in scope. Changed _os.getenv(...) to os.getenv(...) and removed the mid-function import alias. Finding 4 — custom_logger_registry.py: fix MavvrikLogger import order MavvrikLogger was inserted between cloudzero and datadog imports. Alphabetically mavvrik sorts after datadog/datadog_llm_obs/datadog_metrics and before deepeval. Moved import to the correct alphabetical position. Co-Authored-By: Claude Sonnet 4.6 (1M context) --- litellm/litellm_core_utils/custom_logger_registry.py | 2 +- litellm/proxy/proxy_server.py | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/litellm/litellm_core_utils/custom_logger_registry.py b/litellm/litellm_core_utils/custom_logger_registry.py index 19ae28ad5d0..6ad6895aea4 100644 --- a/litellm/litellm_core_utils/custom_logger_registry.py +++ b/litellm/litellm_core_utils/custom_logger_registry.py @@ -18,11 +18,11 @@ from litellm.integrations.azure_storage.azure_storage import AzureBlobStorageLog from litellm.integrations.bitbucket import BitBucketPromptManager from litellm.integrations.braintrust_logging import BraintrustLogger from litellm.integrations.cloudzero.cloudzero import CloudZeroLogger -from litellm.integrations.mavvrik import Logger as MavvrikLogger from litellm.integrations.datadog.datadog import DataDogLogger from litellm.integrations.datadog.datadog_llm_obs import DataDogLLMObsLogger from litellm.integrations.datadog.datadog_metrics import DatadogMetricsLogger from litellm.integrations.deepeval import DeepEvalLogger +from litellm.integrations.mavvrik import Logger as MavvrikLogger from litellm.integrations.dotprompt import DotpromptManager from litellm.integrations.focus.focus_logger import FocusLogger from litellm.integrations.vantage.vantage_logger import VantageLogger diff --git a/litellm/proxy/proxy_server.py b/litellm/proxy/proxy_server.py index 0f4aa544b4c..83272ade03c 100644 --- a/litellm/proxy/proxy_server.py +++ b/litellm/proxy/proxy_server.py @@ -6737,14 +6737,13 @@ class ProxyStartupEvent: # Skip DB load when credentials come from env vars — avoids raising # if prisma_client is not yet connected at startup. data = {} if settings.has_env_vars else await settings.load() - import os as _os client = MavvrikClient( - api_key=data.get("api_key") or _os.getenv("MAVVRIK_API_KEY", ""), + api_key=data.get("api_key") or os.getenv("MAVVRIK_API_KEY", ""), api_endpoint=data.get("api_endpoint") - or _os.getenv("MAVVRIK_API_ENDPOINT", ""), + or os.getenv("MAVVRIK_API_ENDPOINT", ""), connection_id=data.get("connection_id") - or _os.getenv("MAVVRIK_CONNECTION_ID", ""), + or os.getenv("MAVVRIK_CONNECTION_ID", ""), ) uploader = MavvrikUploader(client=client) orchestrator = MavvrikOrchestrator(client=client, uploader=uploader)