From 9f85881730e05e537d014f3d3507e89b0cd85f78 Mon Sep 17 00:00:00 2001 From: Vladimir Babin Date: Sat, 24 Oct 2026 09:26:23 +0300 Subject: [PATCH] fix: treat empty-string mock_response as a mock, not a live request mock_response="" was falsy, so the dispatch in completion() fell through and sent a real request to the provider, while mock_completion() already handles an empty string by returning empty content. Use an explicit None check so an empty mocked answer is honored. --- litellm/main.py | 2 +- tests/unit/test_utils.py | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/litellm/main.py b/litellm/main.py index 327a7a1c4b5..df7e6b85fab 100644 --- a/litellm/main.py +++ b/litellm/main.py @@ -6027,7 +6027,7 @@ def completion( custom_llm_provider=custom_llm_provider, model_id=optional_params.get("model_id"), ) - if mock_response or mock_tool_calls or mock_timeout: + if mock_response is not None or mock_tool_calls or mock_timeout: kwargs.pop("mock_timeout", None) # remove for any fallbacks triggered return mock_completion( model, diff --git a/tests/unit/test_utils.py b/tests/unit/test_utils.py index ad069aa987b..dc1ebae3fed 100644 --- a/tests/unit/test_utils.py +++ b/tests/unit/test_utils.py @@ -157,6 +157,19 @@ def test_post_call_rule_rejects_mock_response(monkeypatch: pytest.MonkeyPatch) - ) +def test_completion_empty_string_mock_response_does_not_make_request() -> None: + response = litellm.completion( + model="openai/gpt-4o-mini", + messages=[{"role": "user", "content": "hi"}], + mock_response="", + api_base="http://127.0.0.1:9", + api_key="sk-test", + num_retries=0, + ) + + assert response.choices[0].message.content == "" + + def test_post_call_rule_rejects_streaming_mock_response(monkeypatch: pytest.MonkeyPatch) -> None: monkeypatch.setattr(litellm, "pre_call_rules", []) monkeypatch.setattr(litellm, "post_call_rules", [_reject_short_post_call_response])