scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-06 08:16:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 178

test: merge minimax reasoning_content regression case into existing test_parse_content_for_reasoning

Browse source 
Addresses reviewer feedback — consolidates coverage into the existing
parametrized test instead of a standalone module.
This commit is contained in:
trakshan-mishra 2026-08-25 19:56:49 +05:30
parent 1b15772c86
commit 577e94847d
2 changed files with 9 additions and 43 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tests/litellm_utils_tests/test_utils.py
View file

@ -1043,6 +1043,15 @@ def test_convert_model_response_object():
"The sky is a canvas of blue",
),
("I am a regular response", None, "I am a regular response"),
(
# Regression for #38197: MiniMax M2.7 puts its entire answer
# inside <think>...</think> with nothing trailing after the
# closing tag. Fall back to the reasoning content instead of
# silently discarding the model's only real output.
"<think>The answer to 2+2 is 4.</think>",
"The answer to 2+2 is 4.",
"The answer to 2+2 is 4.",
),
],
)
def test_parse_content_for_reasoning(content, expected_reasoning, expected_content):

43
tests/minimax_bugfix/test_minimax_reasoning_content_bug.py
View file

@ -1,43 +0,0 @@
"""
Repro for GitHub issue #38197: MiniMax-M2.7 returns message.content empty,
usage all zero, while reasoning_content has valid output, finish_reason=stop.
Root cause (confirmed against source + MiniMax docs, 2026-08-25):
MiniMax M2.7 (with reasoning_split unset/false, the default) returns its
answer wrapped as "<think>...</think><rest of answer>" in a single content
string. litellm.litellm_core_utils.prompt_templates.common_utils.
_parse_content_for_reasoning() splits this with a regex whose second capture
group is everything AFTER the closing </think> tag. When the model's real
answer sits entirely inside the <think> block with nothing after it, that
capture group is an empty string — so `content` comes back "" while the
actual answer is sitting, discarded, in `reasoning_content`.
Tests the parsing function directly — no network, no API key, no mock
server needed, since this isolates exactly where the bug lives.
"""
from litellm.litellm_core_utils.prompt_templates.common_utils import (
_parse_content_for_reasoning,
)
class TestMinimaxReasoningContentBug:
def test_answer_entirely_inside_think_tag_yields_empty_content(self):
raw = "<think>The answer to 2+2 is 4.</think>"
reasoning_content, content = _parse_content_for_reasoning(raw)
print("reasoning_content:", repr(reasoning_content))
print("content:", repr(content))
assert reasoning_content == "The answer to 2+2 is 4."
# Fixed: content now falls back to reasoning_content when nothing
# follows the closing </think> tag, instead of being empty.
assert content == "The answer to 2+2 is 4."
def test_answer_after_think_tag_still_works(self):
raw = "<think>Let me work this out.</think>The answer is 4."
reasoning_content, content = _parse_content_for_reasoning(raw)
assert reasoning_content == "Let me work this out."
assert content == "The answer is 4."