From 569154ef9f036c8b38dbd2f1f79d1474cf90f192 Mon Sep 17 00:00:00 2001 From: ryan-crabbe-berri Date: Mon, 1 Jun 2026 17:18:23 -0700 Subject: [PATCH] fix(vector-stores): log effective query when extra_body overrides it When a caller passes a query inside extra_body, the outbound Vertex Search request used that value but model_call_details recorded the original, so the echoed search_query was stale. Log the effective query from the request body. --- .../vector_stores/search_api/transformation.py | 4 +++- ..._vertex_ai_search_vector_store_transformation.py | 13 +++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/litellm/llms/vertex_ai/vector_stores/search_api/transformation.py b/litellm/llms/vertex_ai/vector_stores/search_api/transformation.py index a6fbe33a866..6bb7885810a 100644 --- a/litellm/llms/vertex_ai/vector_stores/search_api/transformation.py +++ b/litellm/llms/vertex_ai/vector_stores/search_api/transformation.py @@ -152,7 +152,9 @@ class VertexSearchAPIVectorStoreConfig(BaseVectorStoreConfig, VertexBase): if isinstance(extra_body, dict): request_body.update(extra_body) - litellm_logging_obj.model_call_details["query"] = query + litellm_logging_obj.model_call_details["query"] = request_body.get( + "query", query + ) return url, request_body diff --git a/tests/test_litellm/llms/vertex_ai/test_vertex_ai_search_vector_store_transformation.py b/tests/test_litellm/llms/vertex_ai/test_vertex_ai_search_vector_store_transformation.py index 83d9fd703d8..3e7a1c33d58 100644 --- a/tests/test_litellm/llms/vertex_ai/test_vertex_ai_search_vector_store_transformation.py +++ b/tests/test_litellm/llms/vertex_ai/test_vertex_ai_search_vector_store_transformation.py @@ -194,3 +194,16 @@ def test_search_request_joins_list_query(): _, body = _search_request(query=["foo", "bar"]) assert body["query"] == "foo bar" + + +def test_search_request_logs_effective_query_when_extra_body_overrides_query(): + log = SimpleNamespace(model_call_details={}) + + _, body = _search_request( + query="original", + extra_body={"query": "from-extra-body"}, + litellm_logging_obj=log, + ) + + assert body["query"] == "from-extra-body" + assert log.model_call_details["query"] == "from-extra-body"