scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-04 02:31:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 71

test(prometheus): clear cached metric labels after toggling rate-limit flag

Browse source 
The PrometheusLogger caches each metric's label set at construction
time so that labels used at counter.labels(...) time stay consistent
with the labels the metric was registered with. The enterprise
async_post_call_failure_hook test toggles
litellm.prometheus_emit_rate_limit_labels = True AFTER the fixture
has already built the logger, so without invalidating the cache the
rate_limit_category / rate_limit_type labels never reach the mocked
counter and the assert_called_once_with check fails.

Co-authored-by: Yassin Kortam <yassin@berri.ai>
This commit is contained in:
Cursor Agent 2026-05-14 22:49:11 +00:00
parent 9c5ff9d336
commit 5452c2fb30
No known key found for this signature in database
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/enterprise/litellm_enterprise/enterprise_callbacks/test_prometheus_logging_callbacks.py
View file

@ -785,8 +785,13 @@ async def test_async_post_call_failure_hook(prometheus_logger):
"""
# Opt into the unified rate-limit labels so this test exercises the
# full label set surfaced when `prometheus_emit_rate_limit_labels` is on.
# The logger caches each metric's label set at construction time (so the
# labels passed to ``counter.labels(...)`` stay in lock step with the
# labels used to register the metric), so we must invalidate the cache
# after flipping the toggle for the cache to pick up the new label set.
original_emit = litellm.prometheus_emit_rate_limit_labels
litellm.prometheus_emit_rate_limit_labels = True
prometheus_logger._cached_metric_labels.clear()
# Mock the prometheus metrics
prometheus_logger.litellm_proxy_failed_requests_metric = MagicMock()
@ -840,6 +845,7 @@ async def test_async_post_call_failure_hook(prometheus_logger):
)
finally:
litellm.prometheus_emit_rate_limit_labels = original_emit
prometheus_logger._cached_metric_labels.clear()
prometheus_logger.litellm_proxy_failed_requests_metric.labels().inc.assert_called_once()
# Assert total requests metric was incremented with correct labels