scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-10 03:28:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 84

[Fix] conftest snapshot: also reset scalar module attributes

Browse source 
The previous snapshot only tracked list/dict/set values. Tests mutate
scalar module attrs too — master_key, premium_user, prisma_client — and
importlib.reload used to reset those implicitly. Under the snapshot
approach they were leaking between tests, so test_active_callbacks
failed in CI with "No api key passed in." once an earlier test left
master_key set to sk-1234.

Expand the snapshot to cover primitives (str/int/float/bool/bytes/tuple)
and None-valued attributes. Complex object instances are still skipped
to avoid deepcopy issues.
This commit is contained in:
Yuneng Jiang 2026-04-20 21:03:07 -07:00
parent ccf928361b
commit 5411ebedae
No known key found for this signature in database
1 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
tests/proxy_unit_tests/conftest.py
View file

@ -15,12 +15,17 @@ import litellm
import litellm.proxy.proxy_server
def _snapshot_mutable_state(module):
"""Deep-copy every list/dict/set module attribute for later restore.
_SNAPSHOT_TYPES = (list, dict, set, tuple, str, int, float, bool, bytes)
Classes, functions, submodules and primitives are skipped — only the
collections that tests mutate (callbacks, caches, routers, etc.) need
per-test isolation.
def _snapshot_mutable_state(module):
"""Snapshot every module attribute that importlib.reload would have reset.
Covers the top-level assignments that tests mutate — collections
(callbacks, caches, general_settings) plus scalar flags (master_key,
premium_user, etc.) that gate auth and feature behavior. Classes,
functions, submodules and complex object instances are skipped: those
either aren't meant to be reset or can't round-trip through deepcopy.
"""
snapshot = {}
for attr in list(vars(module)):
@ -30,12 +35,12 @@ def _snapshot_mutable_state(module):
value = getattr(module, attr)
except Exception:
continue
if isinstance(value, (list, dict, set)):
if value is None or isinstance(value, _SNAPSHOT_TYPES):
try:
snapshot[attr] = copy.deepcopy(value)
except Exception:
# Unpickleable collections (e.g. holding open clients) can't
# round-trip through deepcopy; skip them rather than crash.
# Skip anything that can't round-trip through deepcopy
# rather than crash collection.
pass
return snapshot