From 52c35413bd8a7d3d8834bc63c08a30e6386febe9 Mon Sep 17 00:00:00 2001 From: ryan-crabbe-berri Date: Tue, 3 Nov 2026 09:18:05 -0800 Subject: [PATCH] test(e2e): check the codex mcp row exits cleanly on both turns --- tests/e2e/codex/mcp_server.py | 3 ++- tests/e2e/codex/test_mcp_tool_e2e.py | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/e2e/codex/mcp_server.py b/tests/e2e/codex/mcp_server.py index fda9091fc36..5d35e620248 100644 --- a/tests/e2e/codex/mcp_server.py +++ b/tests/e2e/codex/mcp_server.py @@ -2,10 +2,11 @@ from __future__ import annotations import os from pathlib import Path +from typing import Final from mcp.server.mcpserver import MCPServer -server = MCPServer("vault") +server: Final = MCPServer("vault") @server.tool() diff --git a/tests/e2e/codex/test_mcp_tool_e2e.py b/tests/e2e/codex/test_mcp_tool_e2e.py index 41e4ecececa..89053c47562 100644 --- a/tests/e2e/codex/test_mcp_tool_e2e.py +++ b/tests/e2e/codex/test_mcp_tool_e2e.py @@ -29,6 +29,7 @@ class TestCodexMcpTool: model=setup.model, cwd=workspace, ) + assert first.exit_code == 0, first assert first.thread_id is not None, first assert any(first_marker in call.output for call in first.mcp_calls), first assert first_marker in first.answer, first @@ -41,5 +42,6 @@ class TestCodexMcpTool: model=setup.model, cwd=workspace, ) + assert second.exit_code == 0, second assert any(second_marker in call.output for call in second.mcp_calls), second assert second_marker in second.answer, second