From 52b66816a4eac93cbb59cd5e286ca70a29635408 Mon Sep 17 00:00:00 2001 From: mrinal Date: Fri, 30 Oct 2026 16:31:45 +0000 Subject: [PATCH] test(mcp): exercise initialization rejection middleware directly Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- .../unit/proxy/mcp_server/test_mcp_logging.py | 27 +++++++++++++------ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/tests/unit/proxy/mcp_server/test_mcp_logging.py b/tests/unit/proxy/mcp_server/test_mcp_logging.py index 5e0d768cde1..aad2e4b27eb 100644 --- a/tests/unit/proxy/mcp_server/test_mcp_logging.py +++ b/tests/unit/proxy/mcp_server/test_mcp_logging.py @@ -7,16 +7,18 @@ from collections.abc import Generator from datetime import datetime from pathlib import Path from typing import Final -from unittest.mock import AsyncMock, patch +from unittest.mock import AsyncMock, MagicMock, patch import pytest from fastapi import HTTPException from mcp import Client from mcp.server.auth.middleware.auth_context import auth_context_var +from mcp.server.context import ServerRequestContext +from mcp.server.session import ServerSession from mcp.shared.exceptions import MCPError -from mcp.types import CallToolResult, EmptyResult, Request, RequestParams, TextContent +from mcp.types import CallToolResult, EmptyResult, InitializeRequestParams, Request, RequestParams, TextContent from mcp.types import Tool as MCPTool -from pydantic import ConfigDict +from pydantic import ConfigDict, ValidationError import litellm from litellm.caching.caching import DualCache @@ -26,6 +28,7 @@ from litellm.proxy.mcp_server.mcp_server_manager import ( MCPServerManager, ) from litellm.proxy.mcp_server.server import ( + _log_sdk_rejection, mcp_server_tool_call, server, set_auth_context, @@ -177,11 +180,19 @@ async def test_sdk_caller_errors_do_not_trigger_llm_alerts( async def test_sdk_initialization_errors_are_not_logged_as_tool_rejections( sdk_rejection_logger: SDKRejectionLogger, ) -> None: - async with Client(server, mode="legacy") as client: - with pytest.raises(MCPError) as rejected: - await client.session.send_request(Request(method="initialize", params=SDKRejectionParams()), EmptyResult) - assert rejected.value.code == -32602 - await client.session.send_ping() + context: Final = ServerRequestContext( + session=MagicMock(spec=ServerSession), + lifespan_context=None, + protocol_version="2025-11-25", + method="initialize", + params={}, + request_id="bad-init", + ) + with pytest.raises(ValidationError) as sdk_error: + InitializeRequestParams.model_validate({}) + with pytest.raises(ValidationError) as rejected: + await _log_sdk_rejection(context, AsyncMock(side_effect=sdk_error.value)) + assert rejected.value is sdk_error.value assert sdk_rejection_logger.pre_calls == 0 assert sdk_rejection_logger.failures == [] assert sdk_rejection_logger.post_failures == 0