From 4f42ead4ca4f1043fbc0a997c162b5fe2e99e8cc Mon Sep 17 00:00:00 2001 From: CrystalVibe28 <82704512+CrystalVibe28@users.noreply.github.com> Date: Thu, 14 May 2026 23:07:19 +0800 Subject: [PATCH] fix(chatgpt): remove image responses env override --- .../chatgpt/image_generation/transformation.py | 7 ++----- .../test_chatgpt_image_generation.py | 18 ++++++++++++------ 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/litellm/llms/chatgpt/image_generation/transformation.py b/litellm/llms/chatgpt/image_generation/transformation.py index b164a05a0b8..c5b27834e25 100644 --- a/litellm/llms/chatgpt/image_generation/transformation.py +++ b/litellm/llms/chatgpt/image_generation/transformation.py @@ -1,5 +1,4 @@ import json -import os import re from typing import TYPE_CHECKING, Any, Dict, List, Optional, Tuple, Union @@ -145,13 +144,11 @@ class ChatGPTImageGenerationConfig(BaseImageGenerationConfig): self._validate_openai_image_generation_params(model, optional_params) # Intentionally pinned fallback for ChatGPT image generation through the - # Codex Responses API. Users can override this per request, via - # litellm_params, or with CHATGPT_IMAGE_RESPONSES_MODEL without requiring - # a LiteLLM release. + # Codex Responses API. Users can override this per request or via + # litellm_params. responses_model = ( optional_params.pop("chatgpt_responses_model", None) or litellm_params.get("chatgpt_responses_model") - or os.getenv("CHATGPT_IMAGE_RESPONSES_MODEL") or "gpt-5.5" ) request: Dict[str, Any] = { diff --git a/tests/image_gen_tests/test_chatgpt_image_generation.py b/tests/image_gen_tests/test_chatgpt_image_generation.py index f980764c117..c6e61fa5799 100644 --- a/tests/image_gen_tests/test_chatgpt_image_generation.py +++ b/tests/image_gen_tests/test_chatgpt_image_generation.py @@ -345,11 +345,8 @@ def test_chatgpt_image_generation_extracts_b64_from_sse_completed_response( assert response._hidden_params["model"] == "gpt-image-2" -def test_chatgpt_image_generation_uses_optional_responses_model_and_env( - monkeypatch, tmp_path -): +def test_chatgpt_image_generation_uses_optional_responses_model(monkeypatch, tmp_path): monkeypatch.setenv("CHATGPT_TOKEN_DIR", str(tmp_path)) - monkeypatch.setenv("CHATGPT_IMAGE_RESPONSES_MODEL", "gpt-env") config = ChatGPTImageGenerationConfig() optional_params = {"chatgpt_responses_model": "gpt-override"} @@ -364,14 +361,23 @@ def test_chatgpt_image_generation_uses_optional_responses_model_and_env( assert request["model"] == "gpt-override" assert "chatgpt_responses_model" not in optional_params - env_request = config.transform_image_generation_request( + litellm_params_request = config.transform_image_generation_request( + model="gpt-image-2", + prompt="draw a cat", + optional_params={}, + litellm_params={"chatgpt_responses_model": "gpt-litellm-param"}, + headers={}, + ) + assert litellm_params_request["model"] == "gpt-litellm-param" + + default_request = config.transform_image_generation_request( model="gpt-image-2", prompt="draw a cat", optional_params={}, litellm_params={}, headers={}, ) - assert env_request["model"] == "gpt-env" + assert default_request["model"] == "gpt-5.5" @pytest.mark.parametrize(