From 4c1cc99d3e64f5aea5ef6c3037bd0044efefcd93 Mon Sep 17 00:00:00 2001 From: er-s-an <92594860+er-s-an@users.noreply.github.com> Date: Fri, 9 Oct 2026 17:05:18 +0800 Subject: [PATCH] style: drop redundant comment and add Final on #45470 regression test Address greptile review on PR #45478: remove explanatory comments and annotate new test locals with Final per AGENTS.md. --- .../anthropic/messages/responses_adapters/transformation.py | 2 -- .../test_responses_adapters_transformation.py | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/litellm/llms/anthropic/messages/responses_adapters/transformation.py b/litellm/llms/anthropic/messages/responses_adapters/transformation.py index 0b48f9aaae2..547a48e5fbc 100644 --- a/litellm/llms/anthropic/messages/responses_adapters/transformation.py +++ b/litellm/llms/anthropic/messages/responses_adapters/transformation.py @@ -288,8 +288,6 @@ class LiteLLMAnthropicToResponsesAPIAdapter: }, ) if btype == "text": - # Emit text in block order so text before/after tool_use is not - # replayed as one trailing assistant message (#45470). return ( { "type": "message", diff --git a/tests/unit/llms/anthropic/messages/responses_adapters/test_responses_adapters_transformation.py b/tests/unit/llms/anthropic/messages/responses_adapters/test_responses_adapters_transformation.py index e72e8555409..efe0c23cbcf 100644 --- a/tests/unit/llms/anthropic/messages/responses_adapters/test_responses_adapters_transformation.py +++ b/tests/unit/llms/anthropic/messages/responses_adapters/test_responses_adapters_transformation.py @@ -673,7 +673,7 @@ class TestTranslateMessagesToResponsesInput: def test_assistant_text_before_and_after_tool_use_preserves_order(self): """Text around tool_use stays in block order, not replayed after (#45470).""" - messages = [ + messages: Final = [ {"role": "user", "content": "weather in Paris?"}, { "role": "assistant", @@ -695,7 +695,7 @@ class TestTranslateMessagesToResponsesInput: ], }, ] - result = _translate_messages(messages) + result: Final = _translate_messages(messages) assert [item["type"] for item in result] == [ "message", "message",