scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-10-03 02:22:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 80

refactor(ui): route MCP env-var calls through shared http client

Browse source 
The merge of litellm_internal_staging brought in the location-pinned fetch()
lint rule from #29723, which bans raw fetch() outside src/lib/http/. The three
MCP per-user env-var helpers (getMCPUserEnvVars, storeMCPUserEnvVars,
listMCPUserEnvVarStatus) still called fetch() directly, pushing networking.tsx
to 244 no-restricted-syntax violations against a grandfathered baseline of 241;
because bulk suppressions are count-based, the overflow invalidated the whole
file's suppression and turned the lint gate red.

They now go through the shared apiClient, matching the rest of the file, which
keeps the count at the 241 baseline with no new grandfathered suppressions.
listMCPUserEnvVarStatus keeps its best-effort empty-list fallback so a failed
status fetch still can't break the page
This commit is contained in:
mateo-berri 2026-06-05 05:41:36 +00:00
parent 4d7f160d25
commit 4929f50b43
No known key found for this signature in database
1 changed files with 11 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
ui/litellm-dashboard/src/components/networking.tsx
View file

@ -9641,21 +9641,7 @@ export const listMCPUserCredentials = async (accessToken: string): Promise<MCPUs
// ============================================================
export const getMCPUserEnvVars = async (accessToken: string, serverId: string): Promise<MCPUserEnvVarsStatus> => {
const url = proxyBaseUrl
? `${proxyBaseUrl}/v1/mcp/server/${serverId}/user-env-vars`
: `/v1/mcp/server/${serverId}/user-env-vars`;
const response = await fetch(url, {
method: "GET",
headers: { [globalLitellmHeaderName]: `Bearer ${accessToken}` },
});
if (!response.ok) {
const err = await response.json().catch(() => ({}));
const detail = (err as { detail?: unknown })?.detail;
const message =
typeof detail === "string" ? detail : (detail as { error?: string })?.error || "Failed to load env vars";
throw new Error(message);
}
return response.json();
return apiClient.get<MCPUserEnvVarsStatus>(`/v1/mcp/server/${serverId}/user-env-vars`, { accessToken });
};
export const storeMCPUserEnvVars = async (
@ -9663,35 +9649,20 @@ export const storeMCPUserEnvVars = async (
serverId: string,
values: Record<string, string>,
): Promise<MCPUserEnvVarsStatus> => {
const url = proxyBaseUrl
? `${proxyBaseUrl}/v1/mcp/server/${serverId}/user-env-vars`
: `/v1/mcp/server/${serverId}/user-env-vars`;
const response = await fetch(url, {
method: "POST",
headers: {
[globalLitellmHeaderName]: `Bearer ${accessToken}`,
"Content-Type": "application/json",
},
body: JSON.stringify({ values }),
return apiClient.post<MCPUserEnvVarsStatus>(`/v1/mcp/server/${serverId}/user-env-vars`, {
accessToken,
body: { values },
});
if (!response.ok) {
const err = await response.json().catch(() => ({}));
const detail = (err as { detail?: unknown })?.detail;
const message =
typeof detail === "string" ? detail : (detail as { error?: string })?.error || "Failed to save env vars";
throw new Error(message);
}
return response.json();
};
export const listMCPUserEnvVarStatus = async (accessToken: string): Promise<MCPUserEnvVarsStatus[]> => {
const url = proxyBaseUrl ? `${proxyBaseUrl}/v1/mcp/user-env-vars/status` : `/v1/mcp/user-env-vars/status`;
const response = await fetch(url, {
method: "GET",
headers: { [globalLitellmHeaderName]: `Bearer ${accessToken}` },
});
if (!response.ok) return [];
return response.json();
// Best-effort status badges: a failure here must not break the page, so fall
// back to an empty list rather than surfacing the error to the caller.
try {
return await apiClient.get<MCPUserEnvVarsStatus[]>("/v1/mcp/user-env-vars/status", { accessToken });
} catch {
return [];
}
};
// ============================================================