scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-08-28 05:25:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 48

Merge pull request #38274 from BerriAI/litellm_test_lint_os_environ

Browse source 
test: gate the test tree on B003 so a test cannot swap os.environ for a plain dict
This commit is contained in:
ryan-crabbe-berri 2026-08-25 16:51:45 -07:00 • committed by GitHub
commit 434add755a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ruff-tests.toml
View file

@ -51,6 +51,10 @@
# F632 `is` against a literal. It compares identity, so it passes only where CPython
# happens to intern the value and stops meaning what it says the moment the
# value is built at runtime
# B003 `os.environ = {...}` rebinds the mapping instead of mutating it, so `putenv`
# never fires and a subprocess still reads the real keys the test believes it
# cleared. The manual restore underneath is skipped whenever the body raises,
# so every later test in that worker inherits a plain dict for an environment
#
# No target-version here on purpose: it resolves from requires-python (>=3.10), so
# 3.11-only builtins like BaseExceptionGroup are correctly flagged in a tree that
@ -78,4 +82,5 @@ lint.select = [
"B023",
"B025",
"F632",
"B003",
]

35
tests/litellm_utils_tests/test_utils.py
View file

@ -328,34 +328,23 @@ def test_trimming_with_untokenizable_field(caplog: pytest.LogCaptureFixture) ->
def test_aget_valid_models():
old_environ = os.environ
os.environ = {"OPENAI_API_KEY": "temp"} # mock set only openai key in environ
with mock.patch.dict(os.environ, {"OPENAI_API_KEY": "temp"}, clear=True):
valid_models = get_valid_models()
print(valid_models)
valid_models = get_valid_models()
print(valid_models)
# list of openai supported llms on litellm
expected_models = (
litellm.open_ai_chat_completion_models | litellm.open_ai_text_completion_models
)
# list of openai supported llms on litellm
expected_models = (
litellm.open_ai_chat_completion_models | litellm.open_ai_text_completion_models
)
assert set(valid_models) == set(expected_models)
# reset replicate env key
os.environ = old_environ
assert set(valid_models) == set(expected_models)
# GEMINI
expected_models = litellm.gemini_models
old_environ = os.environ
os.environ = {"GEMINI_API_KEY": "temp"} # mock set only openai key in environ
with mock.patch.dict(os.environ, {"GEMINI_API_KEY": "temp"}, clear=True):
valid_models = get_valid_models()
valid_models = get_valid_models()
print(valid_models)
assert set(valid_models) == set(expected_models)
# reset replicate env key
os.environ = old_environ
print(valid_models)
assert set(valid_models) == set(litellm.gemini_models)
@pytest.mark.parametrize("custom_llm_provider", ["anthropic", "xai"])