scriptoriumadmin/litellm
1
0
Fork 0
mirror of https://github.com/BerriAI/litellm.git synced 2026-09-09 22:31:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 87

address greptile review feedback (greploop iteration 1)

Browse source 
- Separate save failure from refresh failure: close drawer after successful
  save even if teamInfoCall refresh fails
- Preserve unknown permissions not in availablePermissions when saving,
  preventing silent drops of permissions from newer backend versions

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
yuneng-jiang 2026-03-21 00:21:39 -07:00
parent 4f98b4ea3c
commit 42fe911e1c
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
ui/litellm-dashboard/src/components/team/MemberPermissionsDrawer.tsx
View file

@ -74,14 +74,23 @@ const MemberPermissionsDrawer: React.FC<MemberPermissionsDrawerProps> = ({
if (!accessToken || !member) return;
setSaving(true);
try {
// Preserve unknown permissions not present in the available set
const availableValues = new Set(availablePermissions.map((p) => p.value));
const existingUnknown = (member.extra_permissions || []).filter(
(p) => !availableValues.has(p),
);
const updatedMember: Member = {
...member,
extra_permissions: Array.from(selected),
extra_permissions: [...existingUnknown, ...Array.from(selected)],
};
await teamMemberUpdateCall(accessToken, teamId, updatedMember);
NotificationsManager.success("Permissions updated successfully");
await onUpdate();
onClose();
try {
await onUpdate();
} catch (refreshError) {
console.error("Failed to refresh team data after permission update:", refreshError);
}
} catch (error: any) {
const errMsg = error?.message || "Failed to update permissions";
NotificationsManager.fromBackend(errMsg);