From 425a8fdb3ab8dccccc26cdab1e3de46d76215fe9 Mon Sep 17 00:00:00 2001
From: Ishaan Jaff <ishaanjaffer0324@gmail.com>
Date: Wed, 29 May 2024 16:45:30 -0700
Subject: [PATCH] feat - edit user

---
 .../src/components/edit_user.tsx              | 51 +++++++++++--------
 .../src/components/view_users.tsx             | 38 +++++++-------
 2 files changed, 52 insertions(+), 37 deletions(-)

diff --git a/ui/litellm-dashboard/src/components/edit_user.tsx b/ui/litellm-dashboard/src/components/edit_user.tsx
index 4ffc14f5b4c..d1364c9a425 100644
--- a/ui/litellm-dashboard/src/components/edit_user.tsx
+++ b/ui/litellm-dashboard/src/components/edit_user.tsx
@@ -34,6 +34,15 @@ const EditUserModal: React.FC<EditUserModalProps> = ({ visible, onCancel, user,
     setEditedUser({ ...editedUser, [e.target.name]: e.target.value });
   };
 
+  const handleEditSubmit = async (formValues: Record<string, any>) => {
+    // Call API to update team with teamId and values
+
+    console.log("handleEditSubmit:", formValues);
+    onSubmit(formValues);
+    onCancel();
+  };
+
+
   const handleSubmit = () => {
     onSubmit(editedUser);
     onCancel();
@@ -45,15 +54,21 @@ const EditUserModal: React.FC<EditUserModalProps> = ({ visible, onCancel, user,
 
   return (
 
-    <Modal visible={visible} onCancel={onCancel}>
+    <Modal 
+    visible={visible} 
+    onCancel={onCancel} 
+    footer={null}
+    width={1000}
+    title="Edit User"
+    >
 
-        <Text>
+        {/* <Text>
             {JSON.stringify(user)}
         </Text>
-        
+         */}
         <Form
           form={form}
-          onFinish={handleSubmit}
+          onFinish={handleEditSubmit}
           initialValues={user} // Pass initial values here
           labelCol={{ span: 8 }}
           wrapperCol={{ span: 16 }}
@@ -62,7 +77,8 @@ const EditUserModal: React.FC<EditUserModalProps> = ({ visible, onCancel, user,
           <>
             <Form.Item 
             className="mt-8" 
-            label="user_email" 
+            label="User Email" 
+            tooltip="Email of the User"
             name="user_email">
               <TextInput />
             </Form.Item>
@@ -70,43 +86,38 @@ const EditUserModal: React.FC<EditUserModalProps> = ({ visible, onCancel, user,
             <Form.Item
               label="user_id"
               name="user_id"
-              tooltip="int (optional) - Tokens limit for this deployment: in tokens per minute (tpm). Find this information on your model/providers website"
+              hidden={true}
             >
               <TextInput />
             </Form.Item>
 
             <Form.Item
-              label="user_role"
+              label="User Role"
               name="user_role"
-              tooltip="int (optional) - Tokens limit for this deployment: in tokens per minute (tpm). Find this information on your model/providers website"
             >
               <TextInput />
             </Form.Item>
 
             <Form.Item
-              label="spend"
+              label="Spend (USD)"
               name="spend"
-              tooltip="int (optional) - Tokens limit for this deployment: in tokens per minute (tpm). Find this information on your model/providers website"
+              tooltip="(float) - Spend of all LLM calls completed by this user"
             >
               <InputNumber min={0} step={1} />
             </Form.Item>
 
             <Form.Item
-              label="max_budget"
+              label="User Budget (USD)"
               name="max_budget"
-              tooltip="int (optional) - Tokens limit for this deployment: in tokens per minute (tpm). Find this information on your model/providers website"
+              tooltip="(float) - Maximum budget of this user"
             >
               <InputNumber min={0} step={1} />
             </Form.Item>
 
-            <Form.Item
-              label="rpm"
-              name="rpm"
-              tooltip="int (optional) - Rate limit for this deployment: in requests per minute (rpm). Find this information on your model/providers website"
-            >
-              <InputNumber min={0} step={1} />
-            </Form.Item>
-        <Button onClick={handleSubmit}>Save</Button>
+            <div style={{ textAlign: "right", marginTop: "10px" }}>
+                <Button2 htmlType="submit">Save</Button2>
+            </div>
+
         </>
 
       </Form>
diff --git a/ui/litellm-dashboard/src/components/view_users.tsx b/ui/litellm-dashboard/src/components/view_users.tsx
index c631ff510a6..9f955488cc9 100644
--- a/ui/litellm-dashboard/src/components/view_users.tsx
+++ b/ui/litellm-dashboard/src/components/view_users.tsx
@@ -24,7 +24,7 @@ import {
   Icon,
   TextInput,
 } from "@tremor/react";
-import { userInfoCall } from "./networking";
+import { userInfoCall, userUpdateUserCall } from "./networking";
 import { Badge, BadgeDelta, Button } from "@tremor/react";
 import RequestAccess from "./request_model_access";
 import CreateUser from "./create_user_button";
@@ -65,26 +65,29 @@ const ViewUserDashboard: React.FC<ViewUserDashboardProps> = ({
   const [selectedUser, setSelectedUser] = useState(null);
   const defaultPageSize = 25;
 
-  const handleEditClick = (user) => {
-    console.log("handleEditClick:", user);
-    setSelectedUser(user);
-    setEditModalVisible(true);
-  };
-  
   const handleEditCancel = () => {
     setEditModalVisible(false);
     setSelectedUser(null);
   };
   
-  const handleEditSubmit = async (editedUser) => {
-    // Call your API to update the user with editedUser data
-    // ...
-  
-    // Update the userData state with the updated user data
-    const updatedUserData = userData.map((user) =>
-      user.user_id === editedUser.user_id ? editedUser : user
-    );
-    setUserData(updatedUserData);
+  const handleEditSubmit = async (editedUser: any) => {
+    console.log("inside handleEditSubmit:", editedUser);
+
+    if (!accessToken || !token || !userRole || !userID) {
+      return;
+    }
+
+    userUpdateUserCall(accessToken, editedUser, userRole);
+
+    if (userData) {
+      const updatedUserData = userData.map((user) =>
+        user.user_id === editedUser.user_id ? editedUser : user
+      );
+      setUserData(updatedUserData);
+    }
+    setSelectedUser(null);
+    setEditModalVisible(false);
+    // Close the modal
   };
 
   useEffect(() => {
@@ -234,7 +237,8 @@ const ViewUserDashboard: React.FC<ViewUserDashboardProps> = ({
                          
                          
                          <Icon icon={PencilAltIcon} onClick= {() => {
-                          handleEditClick(user)
+                          setSelectedUser(user)
+                          setEditModalVisible(true)
                         }}>View Keys</Icon>
 
                         <Icon icon={TrashIcon} onClick= {() => {