From 3d7d8f69f4ca903b69aadeb4e47a6ac4ba33ea9d Mon Sep 17 00:00:00 2001 From: mayuriphad Date: Fri, 28 Aug 2026 10:05:55 +0530 Subject: [PATCH] fix(tests): stop patching an SDK internal in the discovery regression test TQ008 flagged patching litellm.proxy.auth.model_checks.get_valid_models. Assert the gate's own return value instead of mocking past it. --- .../proxy/auth/test_model_checks.py | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/tests/test_litellm/proxy/auth/test_model_checks.py b/tests/test_litellm/proxy/auth/test_model_checks.py index 6b18d76bd75..534eeb4fa84 100644 --- a/tests/test_litellm/proxy/auth/test_model_checks.py +++ b/tests/test_litellm/proxy/auth/test_model_checks.py @@ -809,6 +809,11 @@ def test_get_provider_models_admits_providers_without_a_static_catalog(): """litellm_proxy and hosted_vllm have no entry in litellm.models_by_provider (their model list only exists behind the provider's own endpoint), so the static-dict gate must not reject them before endpoint discovery runs. + + Regression check only, not a discovery test: with check_provider_endpoint + left at its default (off), get_valid_models never reaches the network and + falls back to models_by_provider.get(provider, []) -- an empty list, not + None. Before the fix, the gate itself returned None for these providers. """ import litellm from litellm.proxy.auth.model_checks import get_provider_models @@ -817,21 +822,16 @@ def test_get_provider_models_admits_providers_without_a_static_catalog(): assert "litellm_proxy" not in litellm.models_by_provider assert "hosted_vllm" not in litellm.models_by_provider - with patch( - "litellm.proxy.auth.model_checks.get_valid_models", - return_value=["litellm_proxy/gpt-4o"], - ) as mock_get_valid_models: - result = get_provider_models( - "litellm_proxy", - litellm_params=LiteLLM_Params( - model="litellm_proxy/*", - api_base="http://upstream:4000", - api_key="sk-upstream", - ), - ) + result = get_provider_models( + "litellm_proxy", + litellm_params=LiteLLM_Params( + model="litellm_proxy/*", + api_base="http://upstream:4000", + api_key="sk-upstream", + ), + ) - assert result == ["litellm_proxy/gpt-4o"] - mock_get_valid_models.assert_called_once() + assert result == [] def test_get_provider_models_returns_none_for_an_unknown_provider():