Merge 7b11f230bf into 527d882508

litellm/llms/openai/vector_store_files/transformation.py

@@ -27,9 +27,9 @@ def _clean_dict(source: Mapping[str, object]) -> dict[str, object]:
     return {k: v for k, v in source.items() if v is not None}
 
 
-def _visible_attributes(attributes: Mapping[str, object]) -> Mapping[str, str]:
-    """The caller's string attributes, all of them, so the provider enforces its own key limit."""
-    return {str(k): v for k, v in attributes.items() if k != "hidden_params" and isinstance(v, str)}
+def _visible_attributes(attributes: Mapping[str, object]) -> Mapping[str, object]:
+    """The caller's attributes, all of them, so the provider enforces its own key limit."""
+    return {str(k): v for k, v in attributes.items() if k != "hidden_params"}
 
 
 class OpenAIVectorStoreFilesConfig(BaseVectorStoreFilesConfig):

tests/unit/llms/openai/vector_store_files/test_openai_vector_store_files_transformation.py

@@ -1,3 +1,4 @@
+import json
 from typing import Final
 
 import httpx
@@ -7,6 +8,10 @@ from litellm.llms.openai.vector_store_files.transformation import (
     OpenAIVectorStoreFilesConfig,
 )
 from litellm.types.router import GenericLiteLLMParams
+from litellm.types.vector_store_files import (
+    VectorStoreFileCreateRequest,
+    VectorStoreFileUpdateRequest,
+)
 
 
 @pytest.fixture()
@@ -43,10 +48,7 @@ def test_get_complete_url_encodes_vector_store_id(
         litellm_params={},
     )
 
-    assert (
-        url
-        == "https://api.example.com/v1/vector_stores/..%2Fvs_123%3Fx%3D1%23frag/files"
-    )
+    assert url == "https://api.example.com/v1/vector_stores/..%2Fvs_123%3Fx%3D1%23frag/files"
 
 
 def test_transform_create_request(config: OpenAIVectorStoreFilesConfig):
@@ -65,6 +67,84 @@ def test_transform_create_request(config: OpenAIVectorStoreFilesConfig):
     assert payload["attributes"]["key"] == "value"
 
 
+@pytest.mark.parametrize(
+    "attributes",
+    [
+        {
+            "category": "manual",
+            "year": 2024,
+            "score": 0.75,
+            "published": True,
+            "archived": False,
+            "count": 0,
+            "weight": 0.0,
+            "label": "",
+        },
+        {"year": 2024, "archived": False},
+        {},
+    ],
+    ids=["mixed-types", "no-strings", "empty"],
+)
+def test_create_request_preserves_attribute_types(
+    config: OpenAIVectorStoreFilesConfig,
+    attributes: dict[str, str | int | float | bool],
+) -> None:
+    api_base: Final = "https://api.example.com/v1/vector_stores/vs_123/files"
+    create_request: Final[VectorStoreFileCreateRequest] = {
+        "file_id": "file-abc",
+        "attributes": attributes,
+    }
+    expected_json: Final = json.dumps(create_request, sort_keys=True)
+
+    url, payload = config.transform_create_vector_store_file_request(
+        vector_store_id="vs_123",
+        create_request=create_request,
+        api_base=api_base,
+    )
+
+    assert url == api_base
+    assert json.dumps(payload, sort_keys=True) == expected_json
+    assert json.dumps(create_request, sort_keys=True) == expected_json
+
+
+@pytest.mark.parametrize(
+    "attributes",
+    [
+        {
+            "category": "manual",
+            "year": 2024,
+            "score": 0.75,
+            "published": True,
+            "archived": False,
+            "count": 0,
+            "weight": 0.0,
+            "label": "",
+        },
+        {"year": 2024, "archived": False},
+        {},
+    ],
+    ids=["mixed-types", "no-strings", "empty"],
+)
+def test_update_request_preserves_attribute_types(
+    config: OpenAIVectorStoreFilesConfig,
+    attributes: dict[str, str | int | float | bool],
+) -> None:
+    api_base: Final = "https://api.example.com/v1/vector_stores/vs_123/files"
+    update_request: Final[VectorStoreFileUpdateRequest] = {"attributes": attributes}
+    expected_json: Final = json.dumps(update_request, sort_keys=True)
+
+    url, payload = config.transform_update_vector_store_file_request(
+        vector_store_id="vs_123",
+        file_id="file-abc",
+        update_request=update_request,
+        api_base=api_base,
+    )
+
+    assert url == f"{api_base}/file-abc"
+    assert json.dumps(payload, sort_keys=True) == expected_json
+    assert json.dumps(update_request, sort_keys=True) == expected_json
+
+
 _SEVENTEEN_ATTRIBUTES: Final[dict[str, str]] = {f"key_{index}": f"value_{index}" for index in range(17)}
 
 
@@ -110,10 +190,7 @@ def test_transform_file_request_encodes_file_id(config: OpenAIVectorStoreFilesCo
         api_base=api_base,
     )
 
-    assert (
-        url
-        == "https://api.example.com/v1/vector_stores/vs_123/files/..%2F..%2Ffiles%3Fx%3D1%23frag/content"
-    )
+    assert url == "https://api.example.com/v1/vector_stores/vs_123/files/..%2F..%2Ffiles%3Fx%3D1%23frag/content"
     assert params == {}