From 39a41533dd5b0fe4f3b3feb27b69ea82b153db5f Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Tue, 15 Sep 2026 09:20:25 +0000 Subject: [PATCH] test(proxy): justify module-global patches in startup cleanup regression test Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- tests/test_litellm/proxy/test_proxy_server.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/test_litellm/proxy/test_proxy_server.py b/tests/test_litellm/proxy/test_proxy_server.py index f86435a553a..82531d1b533 100644 --- a/tests/test_litellm/proxy/test_proxy_server.py +++ b/tests/test_litellm/proxy/test_proxy_server.py @@ -7631,9 +7631,15 @@ async def test_startup_schedules_first_retention_cleanup_soon_after_boot(monkeyp mock_proxy_logging.db_spend_update_writer = MagicMock() with ( - patch("litellm.proxy.proxy_server.proxy_config", _mock_scheduled_proxy_config()), - patch("litellm.proxy.proxy_server.store_model_in_db", False), - patch("litellm.proxy.proxy_server.get_secret_bool", return_value=False), + patch( # test-quality-ok: initialize_scheduled_background_jobs reads these module globals, there is no seam to inject them + "litellm.proxy.proxy_server.proxy_config", _mock_scheduled_proxy_config() + ), + patch( # test-quality-ok: same module global as above + "litellm.proxy.proxy_server.store_model_in_db", False + ), + patch( # test-quality-ok: same module global as above + "litellm.proxy.proxy_server.get_secret_bool", return_value=False + ), ): before = datetime.now(timezone.utc) await ProxyStartupEvent.initialize_scheduled_background_jobs(