From 3908c4eda265c0da033dc74814a48624004d9b47 Mon Sep 17 00:00:00 2001 From: mateo-berri <277851410+mateo-berri@users.noreply.github.com> Date: Sat, 20 Jun 2026 05:54:43 +0000 Subject: [PATCH] test(e2e): drop misleading skip comment on require_successful_call require_successful_call fails hard, it does not skip; the trailing comment was factually wrong. The function name already states intent, so the comment is removed in both per-model and tag budget helpers. --- tests/e2e/budgets/test_model_max_budget_e2e.py | 2 +- tests/e2e/budgets/test_tag_budget_e2e.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/e2e/budgets/test_model_max_budget_e2e.py b/tests/e2e/budgets/test_model_max_budget_e2e.py index 34616624c12..c11e50f679c 100644 --- a/tests/e2e/budgets/test_model_max_budget_e2e.py +++ b/tests/e2e/budgets/test_model_max_budget_e2e.py @@ -24,7 +24,7 @@ FREE_MODEL = "gemini-2.5-flash" def _call(client: BudgetClient, key: str, model: str): result = client.chat(key, model, f"hi {unique_marker()}", max_tokens=16) if not result.ok and not is_budget_block(result): - require_successful_call(result) # non-budget error -> skip + require_successful_call(result) return result diff --git a/tests/e2e/budgets/test_tag_budget_e2e.py b/tests/e2e/budgets/test_tag_budget_e2e.py index 6f71b1b204b..492aa89b528 100644 --- a/tests/e2e/budgets/test_tag_budget_e2e.py +++ b/tests/e2e/budgets/test_tag_budget_e2e.py @@ -29,7 +29,7 @@ def _tagged_call(client: BudgetClient, key: str, tag: str): max_tokens=16, ) if not result.ok and not is_budget_block(result): - require_successful_call(result) # non-budget error -> skip + require_successful_call(result) return result