test(vertex): spy on raw_decode instead of json.loads in accumulator regression tests

Post-migration to the shared JSONFragmentAccumulator, Vertex's decode
path goes through json.JSONDecoder.raw_decode, not json.loads. The two
O(n^2)/partial-fragment regression tests still patched json.loads, which
that path never calls, so both passed unconditionally regardless of
whether the underlying implementation regressed. Verified by simulating
an eager-reparse regression: both tests now fail against it and pass
against the correct implementation.
This commit is contained in:
Deepanshu 2026-08-25 16:41:31 -04:00
parent 2fb24c1f24
commit 34a204378a

View file

@ -3002,8 +3002,11 @@ def test_accumulated_json_does_not_reparse_every_fragment():
The buffer only becomes a complete JSON object on the final fragment, so a
correct implementation parses it ~once, not once per fragment. We assert the
full chunk still parses correctly AND that json.loads is not called on every
fragment (which is what made it quadratic).
full chunk still parses correctly AND that the buffer is not decoded on
every fragment (which is what made it quadratic). Post-migration to the
shared JSONFragmentAccumulator, decoding goes through
`json.JSONDecoder.raw_decode`, not `json.loads` (see the equivalent
Anthropic tests) so the spy targets that call, not `json.loads`.
"""
from litellm.llms.vertex_ai.gemini.vertex_and_google_ai_studio_gemini import (
ModelResponseIterator,
@ -3024,7 +3027,9 @@ def test_accumulated_json_does_not_reparse_every_fragment():
assert len(fragments) > 10, "need a multi-fragment payload to exercise the bug"
parsed = None
with patch("json.loads", wraps=json.loads) as spy:
with patch.object(
json.JSONDecoder, "raw_decode", autospec=True, side_effect=json.JSONDecoder.raw_decode
) as spy:
for fragment in fragments:
out = iterator.handle_accumulated_json_chunk(chunk=fragment)
if out is not None:
@ -3035,14 +3040,16 @@ def test_accumulated_json_does_not_reparse_every_fragment():
assert parsed.choices[0].delta.content == text, "content must be preserved intact"
assert parse_calls <= 2, (
f"json.loads was called {parse_calls} times for {len(fragments)} "
f"raw_decode was called {parse_calls} times for {len(fragments)} "
"fragments; the O(n^2) per-fragment re-parse has regressed"
)
def test_accumulated_json_partial_fragment_returns_none_without_parsing():
"""A fragment that cannot complete the JSON must not trigger a json.loads
parse of the whole growing buffer (issue #26181)."""
"""A fragment that cannot complete the JSON must not trigger a decode
attempt over the whole growing buffer (issue #26181). Decoding goes
through `json.JSONDecoder.raw_decode` post-JSONFragmentAccumulator
migration, not `json.loads`."""
from litellm.llms.vertex_ai.gemini.vertex_and_google_ai_studio_gemini import (
ModelResponseIterator,
)
@ -3054,7 +3061,9 @@ def test_accumulated_json_partial_fragment_returns_none_without_parsing():
)
iterator.chunk_type = "accumulated_json"
with patch("json.loads", wraps=json.loads) as spy:
with patch.object(
json.JSONDecoder, "raw_decode", autospec=True, side_effect=json.JSONDecoder.raw_decode
) as spy:
result = iterator.handle_accumulated_json_chunk(
chunk='{"candidates": [{"content": {"parts": [{"text": "partial'
)